? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 Apr 2016

Pull Request for Improvement.

Summary of Changes

This PR adds a fixed position and ability to drag the debug console.

Now the page is always the same but with a debug console that is fixed in a position. No need to scroll down to the bottom of the page to check the debug results.

Testing Instructions

  1. Use latest staging.
  2. Enable the debug console.
  3. Check the debug console is always on the bottom of the page (you have to scroll down always).
  4. Apply patch.
  5. Check the debug console is always fixed on top right of the screen and opens on clear.
  6. Check you can drag the console to another location if you need (with the drag icon).
  7. On a long page, scroll down and see if the debug console is always there.

image

Observations

Please note the js files added in this PR are the jquery ui draggable events.

Improvements suggestions are welcomed.

avatar andrepereiradasilva andrepereiradasilva - open - 14 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

ups, notice some strange things. will need more work. don't test yet.

avatar brianteeman brianteeman - change - 14 Apr 2016
Category Front End UI/UX
avatar brianteeman brianteeman - change - 14 Apr 2016
Category Front End UI/UX UI/UX
avatar brianteeman
brianteeman - comment - 14 Apr 2016

I know where you are going and I love the idea. One thing I would add would be a collapse/expand all link in the title bar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

@brianteeman can you check? and give feedback.

avatar MATsxm
MATsxm - comment - 14 Apr 2016

That is REALLY great :+1:

Just note that if you open the console, it is then impossible to reach the icon to drag it until you close all the tabs.

screen shot 2016-04-14 at 10 55 45

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar MATsxm MATsxm - test_item - 14 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on ba9821f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar infograf768
infograf768 - comment - 14 Apr 2016

Unsuccessful here:
Some debug content is clipped and no way to access to it, even on big screens (not speaking of modals).
Example: before patch I can go to bottom of the Language Files Loaded :

screen shot 2016-04-14 at 18 15 15

After patch I can't (missing 10 of them):

screen shot 2016-04-14 at 18 11 43

avatar infograf768 infograf768 - test_item - 14 Apr 2016 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 14 Apr 2016

I have tested this item :red_circle: unsuccessfully on ba9821f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

humm seems we need to have a small max-height for the content area...

avatar brianteeman
brianteeman - comment - 14 Apr 2016

Two issues
1.no matter where you move it to or what you have expanded - it moves back to being minimised and on the top right on a page load
2. As @infograf768 says you miss the very bottom of the output - not just language strings the same can be seen with queries


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

reggarding "2. As @infograf768 says you miss the very bottom of the output - not just language strings the same can be seen with queries"

i think now it will show.

avatar infograf768
infograf768 - comment - 14 Apr 2016

Will test tomorrow, I suggest to also test in modal views.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

yeah, more work is needed i guess.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar brianteeman
brianteeman - comment - 14 Apr 2016

The height issue is fixed

New problems (or ones I just didnt spot before)

  1. Profile information Time and Memory bars are larger than the container box
  2. Database query explains are larger than the container box (note these only break out of the container on hover)
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

the height issue is also solved in small height screens and modals since if those it uses the current (pre PR) display.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

@brianteeman can you attach a screenshot?

avatar brianteeman
brianteeman - comment - 14 Apr 2016

Better than that - grab some popcorn and watch the movie

http://i.tee.mn/debug2.gif


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

there are still some issues. ...

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

@brianteeman can you check now?

image

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar brianteeman
brianteeman - comment - 14 Apr 2016

The issue about breaking out of the box are now resolved.

Can you look at the login screen
gx5d

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

@brianteeman what is the issue with the login screen?

avatar brianteeman
brianteeman - comment - 14 Apr 2016

without new-debug enabled the login is about 170px from the top of the screen
with new-deug enabled its as per the screenshot

1.no matter where you move it to or what you have expanded - it moves back to being minimised and on the top right on a page load

Still annoys me a lot - maybe its just me

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

without new-debug enabled the login is about 170px from the top of the screen
with new-deug enabled its as per the screenshot

actually that already happens with the current debug

avatar brianteeman
brianteeman - comment - 14 Apr 2016

Ah I see what you mean - I guess because the debug was pushed up against the login before it wasnt as obvious. Not a big deal

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

i think it's an html error or something that puts the browser in quirks rendering mode or something.

I will check that also when i have time.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

@brianteeman i just discovered that the login form not centering has not to do with the system debug plugin, but with the debug global configuration setting.

You can check that by:
1. Enabling debug in system config
2. Disabling the system debug plugin
3. Logoff (or use other anonymous browser tab)
4. See that there is no debug console and yet the login form screen is not centered.

So i will not solve that is this PR.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016
avatar brianteeman
brianteeman - comment - 15 Apr 2016

Which can be removed then with your PR ;)

On 15 April 2016 at 12:37, andrepereiradasilva notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman, just discovered why the
login form goes to top on debug mode.

See
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/login.php#L88-L98


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9910 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

... ok

avatar designbengel
designbengel - comment - 15 Apr 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

@designbengel thanks. what browser did you used?

avatar designbengel
designbengel - comment - 15 Apr 2016

... Sorry, sure! I forgot to add that information. It´s Chrome Version 49.0.2623.112 (64-bit)
and: i accidentally moved out the box outside the screen and couldn´t move it back again.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

... Sorry, sure! I forgot to add that information. It´s Chrome Version 49.0.2623.112 (64-bit)

Ok will check.

i accidentally moved out the box outside the screen and couldn´t move it back again.

refresh the page :smile: eheh

avatar designbengel
designbengel - comment - 15 Apr 2016

I tested another patch with opera Browser with yours still applied and the box looks like this in Opera:
https://www.dropbox.com/s/jyujbi1qgpw9i9v/Screenshot%202016-04-15%2014.54.05.png?dl=0

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

that's really strange since opera rendering machine is the same as chrome.

avatar cheiff cheiff - test_item - 15 Apr 2016 - Tested successfully
avatar cheiff
cheiff - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 5651766

I have tested this successfully in Firefox 45 and Chrome 50.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Apr 2016

This PR has received new commits.

CC: @cheiff, @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

mobile issues on login screen solved.

now i need to check the @designbengel visual problem and after it should be ready for testing.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

@designbengel the opera problem seems to be because of your screen size.

The static floating debug console only apperas when screen size @media (max-height: 650px), (max-width: 1260px). in other words, width higher than 1260px and height higher than 650px.

The chrome profile bars problem i can't reproduce it. Are you using chrome for windows?

avatar MATsxm MATsxm - test_item - 16 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 16 Apr 2016

I have tested this item :white_check_mark: successfully on bd398b2

Tested (zoom 100%) on Chrome 50.0.2661.75 m (+Yandex-Chromium) / FF 45.0.2 / Edge 25.105 and everything looks fine here, even issues previously reported.
Thanks for this great one


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar brianteeman
brianteeman - comment - 22 Apr 2016

I still have an issue with the time and memory bars breaking out of the window
This screenshot shows in order from left to right
Safari Firefox Chrome all on osx
screen shot 2016-04-22 at 09 50 17


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Apr 2016

the thing is i don't have a mac to check that one...
anyone can point what is wrong there on mac?

avatar brianteeman
brianteeman - comment - 22 Apr 2016

I will try and spend some time tomorrow to inviestigate


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 7 May 2016

@brianteeman did you manage to get time to check the mac issue?

avatar brianteeman
brianteeman - comment - 8 May 2016

Sorry not yet - but i have not forgotten

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 May 2016

This PR has received new commits.

CC: @cheiff, @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 May 2016

changed from 80em to 78em as suggested.

avatar brianteeman brianteeman - test_item - 12 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2016

I have tested this item :white_check_mark: successfully on 5237c8f

Perfect thanks

One more quick test please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 May 2016

there a js error when you have debug global config disabled and system debug plugin enabled.
don't test yet.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 May 2016

This PR has received new commits.

CC: @brianteeman, @cheiff, @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 May 2016

solved

avatar brianteeman brianteeman - test_item - 12 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2016

I have tested this item :white_check_mark: successfully on 24723ea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar conconnl conconnl - test_item - 2 Jul 2016 - Tested successfully
avatar conconnl
conconnl - comment - 2 Jul 2016

I have tested this item successfully on 24723ea

A great improvement indeed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar brianteeman brianteeman - change - 3 Jul 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 3 Jul 2016

Finally RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 3 Jul 2016

Conflicts.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Jul 2016

This PR has received new commits.

CC: @brianteeman, @cheiff, @conconnl, @infograf768, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Jul 2016

conflicts fixed

avatar ggppdk ggppdk - test_item - 3 Jul 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 3 Jul 2016

I have tested this item successfully on 7bc5fbc

Just a comment,
about dragging, i would prefer that the full header "Joomla Debug Console" was the drag handle

just asking why use:
handle: ".header .drag",

and not ? (i tested and it works too):
handle: ".header",


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9910.

avatar roland-d roland-d - change - 16 Jul 2016
Category UI/UX Feature Request UI/UX
avatar roland-d roland-d - change - 16 Jul 2016
Labels
avatar roland-d roland-d - change - 16 Jul 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2016
Category UI/UX Feature Request Templates (admin) Administration Libraries JavaScript Plugins Front End UI/UX Feature Request
avatar brianteeman brianteeman - change - 5 Aug 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 3 Sep 2016

OK So I'm not convinced that this is actually useful. I know scrolling down to the bottom of the page is a pain. But my opinion is that having to drag this around into exactly the correct position is going to be an even bigger pain. On top of that it's still not trivial to use. For example testing now I moved it into roughly the center of the screen. Opened the session tab and then found that it expanded off the edge of the page and i couldn't drag it, I then had to close the console, reposition the modal and reopen it again. But even aside from that (bug?) is it really that much easier than what we have now?

avatar andrepereiradasilva andrepereiradasilva - close - 3 Sep 2016
avatar wilsonge wilsonge - close - 3 Sep 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Sep 2016

Actually @wilsonge i'm not convinced too now.

I been thinking of closing this PR for sometime.
I now think the debug panel should be like a sidepanel menu or something, but i lack of css knowledge to do that. Something like this http://www.w3schools.com/howto/howto_js_sidenav.asp

So i will close this. Sorry all testers but i don't want to pursue this anymore.

avatar andrepereiradasilva andrepereiradasilva - change - 3 Sep 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-09-03 23:47:55
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 3 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 3 Sep 2016
avatar gorgonz
gorgonz - comment - 31 Oct 2016

could someone remove milestone 3.7 or something appropriate, because i try to create a list of new feature in 3.7 and it shouldn't be listed at the moment ;-)

avatar wilsonge wilsonge - change - 31 Oct 2016
Milestone Removed:
avatar wilsonge
wilsonge - comment - 31 Oct 2016

Removed - thanks for the prompt

Add a Comment

Login with GitHub to post a comment