User tests: Successful: Unsuccessful:
Pull Request for Improvement.
This PR adds a fixed position and ability to drag the debug console.
Now the page is always the same but with a debug console that is fixed in a position. No need to scroll down to the bottom of the page to check the debug results.
Please note the js files added in this PR are the jquery ui
draggable
events.
Improvements suggestions are welcomed.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Front End UI/UX |
Category | Front End UI/UX | ⇒ | UI/UX |
I know where you are going and I love the idea. One thing I would add would be a collapse/expand all link in the title bar
@brianteeman can you check? and give feedback.
That is REALLY great
Just note that if you open the console, it is then impossible to reach the icon to drag it until you close all the tabs.
Thanks
I have tested this item successfully on ba9821f
I have tested this item unsuccessfully on ba9821f
humm seems we need to have a small max-height for the content area...
Two issues
1.no matter where you move it to or what you have expanded - it moves back to being minimised and on the top right on a page load
2. As @infograf768 says you miss the very bottom of the output - not just language strings the same can be seen with queries
This PR has received new commits.
CC: @infograf768, @MATsxm
reggarding "2. As @infograf768 says you miss the very bottom of the output - not just language strings the same can be seen with queries"
i think now it will show.
Will test tomorrow, I suggest to also test in modal views.
yeah, more work is needed i guess.
This PR has received new commits.
CC: @infograf768, @MATsxm
This PR has received new commits.
CC: @infograf768, @MATsxm
The height issue is fixed
New problems (or ones I just didnt spot before)
the height issue is also solved in small height screens and modals since if those it uses the current (pre PR) display.
@brianteeman can you attach a screenshot?
Better than that - grab some popcorn and watch the movie
This PR has received new commits.
CC: @infograf768, @MATsxm
This PR has received new commits.
CC: @infograf768, @MATsxm
there are still some issues. ...
This PR has received new commits.
CC: @infograf768, @MATsxm
This PR has received new commits.
CC: @infograf768, @MATsxm
@brianteeman can you check now?
This PR has received new commits.
CC: @infograf768, @MATsxm
This PR has received new commits.
CC: @infograf768, @MATsxm
@brianteeman what is the issue with the login screen?
without new-debug enabled the login is about 170px from the top of the screen
with new-deug enabled its as per the screenshot
1.no matter where you move it to or what you have expanded - it moves back to being minimised and on the top right on a page load
Still annoys me a lot - maybe its just me
This PR has received new commits.
CC: @infograf768, @MATsxm
without new-debug enabled the login is about 170px from the top of the screen
with new-deug enabled its as per the screenshot
actually that already happens with the current debug
Ah I see what you mean - I guess because the debug was pushed up against the login before it wasnt as obvious. Not a big deal
i think it's an html error or something that puts the browser in quirks rendering mode or something.
I will check that also when i have time.
@brianteeman i just discovered that the login form not centering has not to do with the system debug plugin, but with the debug global configuration setting.
You can check that by:
1. Enabling debug in system config
2. Disabling the system debug plugin
3. Logoff (or use other anonymous browser tab)
4. See that there is no debug console and yet the login form screen is not centered.
So i will not solve that is this PR.
@brianteeman, just discovered why the login form goes to top on debug mode.
See https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/login.php#L88-L98
Which can be removed then with your PR ;)
On 15 April 2016 at 12:37, andrepereiradasilva notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman, just discovered why the
login form goes to top on debug mode.See
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/login.php#L88-L98—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9910 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
... ok
there are still issues with breaking the box
https://www.dropbox.com/s/8yivod42j7o7gm2/Screenshot%202016-04-15%2014.44.37.png?dl=0
@designbengel thanks. what browser did you used?
... Sorry, sure! I forgot to add that information. It´s Chrome Version 49.0.2623.112 (64-bit)
and: i accidentally moved out the box outside the screen and couldn´t move it back again.
... Sorry, sure! I forgot to add that information. It´s Chrome Version 49.0.2623.112 (64-bit)
Ok will check.
i accidentally moved out the box outside the screen and couldn´t move it back again.
refresh the page eheh
I tested another patch with opera Browser with yours still applied and the box looks like this in Opera:
https://www.dropbox.com/s/jyujbi1qgpw9i9v/Screenshot%202016-04-15%2014.54.05.png?dl=0
that's really strange since opera rendering machine is the same as chrome.
I have tested this item successfully on 5651766
I have tested this successfully in Firefox 45 and Chrome 50.
This PR has received new commits.
CC: @cheiff, @infograf768, @MATsxm
mobile issues on login screen solved.
now i need to check the @designbengel visual problem and after it should be ready for testing.
@designbengel the opera problem seems to be because of your screen size.
The static floating debug console only apperas when screen size @media (max-height: 650px), (max-width: 1260px)
. in other words, width higher than 1260px and height higher than 650px.
The chrome profile bars problem i can't reproduce it. Are you using chrome for windows?
I have tested this item successfully on bd398b2
Tested (zoom 100%) on Chrome 50.0.2661.75 m (+Yandex-Chromium) / FF 45.0.2 / Edge 25.105 and everything looks fine here, even issues previously reported.
Thanks for this great one
I still have an issue with the time and memory bars breaking out of the window
This screenshot shows in order from left to right
Safari Firefox Chrome all on osx
the thing is i don't have a mac to check that one...
anyone can point what is wrong there on mac?
I will try and spend some time tomorrow to inviestigate
@brianteeman did you manage to get time to check the mac issue?
Sorry not yet - but i have not forgotten
This PR has received new commits.
CC: @cheiff, @infograf768, @MATsxm
changed from 80em to 78em as suggested.
I have tested this item successfully on 5237c8f
Perfect thanks
One more quick test please
there a js error when you have debug global config disabled and system debug plugin enabled.
don't test yet.
This PR has received new commits.
CC: @brianteeman, @cheiff, @infograf768, @MATsxm
solved
I have tested this item successfully on 24723ea
I have tested this item
A great improvement indeed.
Status | Pending | ⇒ | Ready to Commit |
Finally RTC
Labels |
Added:
?
|
Conflicts.
This PR has received new commits.
CC: @brianteeman, @cheiff, @conconnl, @infograf768, @MATsxm
conflicts fixed
I have tested this item
Just a comment,
about dragging, i would prefer that the full header "Joomla Debug Console" was the drag handle
just asking why use:
handle: ".header .drag",
and not ? (i tested and it works too):
handle: ".header",
Category | UI/UX | ⇒ | Feature Request UI/UX |
Labels |
Milestone |
Added: |
Category | UI/UX Feature Request | ⇒ | Templates (admin) Administration Libraries JavaScript Plugins Front End UI/UX Feature Request |
Labels |
Added:
?
|
OK So I'm not convinced that this is actually useful. I know scrolling down to the bottom of the page is a pain. But my opinion is that having to drag this around into exactly the correct position is going to be an even bigger pain. On top of that it's still not trivial to use. For example testing now I moved it into roughly the center of the screen. Opened the session tab and then found that it expanded off the edge of the page and i couldn't drag it, I then had to close the console, reposition the modal and reopen it again. But even aside from that (bug?) is it really that much easier than what we have now?
Actually @wilsonge i'm not convinced too now.
I been thinking of closing this PR for sometime.
I now think the debug panel should be like a sidepanel menu or something, but i lack of css knowledge to do that. Something like this http://www.w3schools.com/howto/howto_js_sidenav.asp
So i will close this. Sorry all testers but i don't want to pursue this anymore.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 23:47:55 |
Closed_By | ⇒ | andrepereiradasilva |
Labels |
Removed:
?
|
could someone remove milestone 3.7 or something appropriate, because i try to create a list of new feature in 3.7 and it shouldn't be listed at the moment ;-)
Milestone |
Removed: |
Removed - thanks for the prompt
ups, notice some strange things. will need more work. don't test yet.