? Success
Pull Request for # 9888

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
14 Apr 2016

Pull Request for Issue #9888 .

Summary of Changes

  • addition of a clear div for modal-footer to fix display issue reported in #9888 and closed #9897
  • refactory of the com_templates hardcoded bootsrap modals in default.php, to use JLayouts/modal (the issue was not using the Jlayout modal which includes core hack script to fix BS modal issues)
  • addition of each modal body and footer in a separated template
  • code style and better handler to detect when auto scrolling to be added and adjust modal height on small devices

Testing Instructions

TEST on current STAGING ONLY!
See #9888 (comment) for screenshots showing issue, and to help testing this patch.
In addition, test that all other modals (batch, users, versions...) are still working as before.
Same testing requirement as for PR #9817 (comment)

Note on com_templates admin
In component templates, admin side, modal buttons to be tested:

  • Copy template (collapseModal)
  • Rename File (renameModal)
  • Delete File (deleteModal)
  • New File (fileModal)
  • Manage Folders (folderModal)
  • Resize Image (resizeModal)

A code review by PLT is welcome! (as addition of 12 news view files...)

avatar JoomliC JoomliC - open - 14 Apr 2016
avatar JoomliC JoomliC - change - 14 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Apr 2016
Category Layout Templates (admin)
avatar brianteeman brianteeman - change - 14 Apr 2016
Title
Converts com_templates hardcoded BS modals to use JLayout/modal + Fix
Converts com_templates hardcoded BS modals to use JLayout/modal + Fix
avatar brianteeman brianteeman - change - 14 Apr 2016
Rel_Number 0 9888
Relation Type Pull Request for
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Apr 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on b041dfb

- Test like above described on com_template, Protostar (Hathor looks like don't use Modals).

avatar brianteeman brianteeman - test_item - 14 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on b041dfb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9908.

avatar brianteeman brianteeman - change - 14 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 14 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9908.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - alter_testresult - 15 Apr 2016 - franz-wohlkoenig: Tested successfully
avatar rdeutz rdeutz - alter_testresult - 15 Apr 2016 - brianteeman: Tested successfully
avatar rdeutz rdeutz - reference | 1c1847e - 15 Apr 16
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - change - 15 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-15 05:06:03
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Removed: ?
avatar Kubik-Rubik Kubik-Rubik - reference | 87881a1 - 29 Apr 16
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment