?
Referenced as Pull Request for: # 9908
avatar brianteeman
brianteeman
13 Apr 2016

Steps to reproduce the issue

Current staging only

Go to template manager and templates, select a template and then select new file from the toolbar

Expected result

screen shot 2016-04-13 at 05 07 56

Actual result

screen shot 2016-04-13 at 05 08 15

System information (as much as possible)

Additional comments

avatar brianteeman brianteeman - open - 13 Apr 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

something to do with the modal-body class it seems

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016
avatar JoomliC
JoomliC - comment - 13 Apr 2016

@andrepereiradasilva and @brianteeman i've got it!
This issue is not link directly to this, as the issue is due to a wrong selector for modal script: $selector Unique DOM identifier for the modal. CSS id without #.

There's a quick fix for this issue with template edit modals: adding over-flow:hidden to .modal-body class, but this not fix overflow for the modal... I'm searching now where the modal id is set for both buttons folder and file, as modal selector in DOM is isisModal for both, but should be unique : folderModal and fileModal.

So, the srolling script fails as not the good id set as selector...

I'm currently searching for a fix for the template modals ;-)

avatar JoomliC JoomliC - reference | f1573cf - 13 Apr 16
avatar JoomliC JoomliC - reference | 8686573 - 13 Apr 16
avatar JoomliC
JoomliC - comment - 13 Apr 2016

I've opened a PR only to fix the display issue: #9897

About the $selector i think there's another issue, as the modal layout always get the same id for each modal ($template-modal) when it should be unique for each modal: collapseModal, folderModal, fileModal, ...

So, the display will be ok, but script used in modal main layout will not have any effect due to the wrong selector DOM identifier for each modal...
Note: i've found this not related issue to the current issue on display, only in the template edition page... (maybe to do the way com_templates manage the modals for buttons... all in the same files, and not in layouts ?...)

avatar JoomliC JoomliC - reference | dc3e6e7 - 13 Apr 16
avatar JoomliC
JoomliC - comment - 14 Apr 2016

Opened a PR (and close #9897) to fix com_templates PR, as well as display issue.
Now each modal in com_templates template view use JLayouts ;-)
#9908

avatar brianteeman
brianteeman - comment - 14 Apr 2016

Closed as we have a PR for testing - thank @joomlic


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9888.

avatar brianteeman brianteeman - change - 14 Apr 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-04-14 13:21:01
Closed_By brianteeman
avatar brianteeman brianteeman - close - 14 Apr 2016

Add a Comment

Login with GitHub to post a comment