? Success
Pull Request for # 8199

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
13 Apr 2016

Redo of PR #8199 by @FPerisa
Original PR description:

A Solution for issue #5563

The issue:
Mobile users could have problems to use the form for searching tags and their articles, because it has no buttons.

My solution:
Like the issue maker wanted it, I added one button for entering the form field and one button for clearing the input of the field.

Testing instructions

  • Go to the searching form for tags "/all-tags"
  • Without the patch you see only an input form field and you submit it with pushing enter
  • With the patch you see nice new buttons
  • Try them out!
  • Do the same with the other form where you search the articles of one tag, e.g. "/all-tags/4-green"

Expected result:
Two new buttons can be used for submitting the form and clearing the input.
The clear button works only when the form got submitted once, because the form field submits immediately, when the user clicks out of it.

Worked as a group on that issue: @icampus @kathastaden @flow87 @xsability

avatar wojsmol wojsmol - open - 13 Apr 2016
avatar wojsmol wojsmol - change - 13 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Rel_Number 0 8199
Relation Type Pull Request for
avatar brianteeman brianteeman - test_item - 13 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on c7bb1e7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar brianteeman brianteeman - change - 13 Apr 2016
Category Accessibility Front End
avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar wojsmol
wojsmol - comment - 13 Apr 2016

@andrepereiradasilva Please test

avatar brianteeman brianteeman - test_item - 14 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on 07f29eb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar brianteeman
brianteeman - comment - 14 Apr 2016

I am wondering if the search and cancel buttons should be swapped around. It seems wrong to me that you enter some text and then have to tab twice to get to the search button.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar brianteeman
brianteeman - comment - 14 Apr 2016

To be clear I mean like this
screen shot 2016-04-14 at 04 36 50


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar brianteeman brianteeman - test_item - 14 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Apr 2016

I have tested this item :white_check_mark: successfully on 754ca02

Much better - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar wojsmol
wojsmol - comment - 14 Apr 2016

We need one more tester.
CC @andrepereiradasilva

avatar waader waader - test_item - 15 Apr 2016 - Tested successfully
avatar waader
waader - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 754ca02

Thanks @wojsmol! Can you add this also to the "compact list of tagged items"- view?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar brianteeman brianteeman - change - 15 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9899.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 15 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 15 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-15 12:18:11
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Apr 2016
avatar rdeutz rdeutz - reference | 7bb4592 - 15 Apr 16
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Removed: ?
avatar wojsmol
wojsmol - comment - 15 Apr 2016

@waader Shortly I prepare a separate PR.

avatar wojsmol wojsmol - head_ref_deleted - 15 Apr 2016
avatar wojsmol
wojsmol - comment - 15 Apr 2016

@brianteeman @waader Please test #9940

avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment