[#8199] - [Accessibility] Joomla Article - Tag: Add 'Search' & 'Clear text' button near search text field
- Closed
- 13 Apr 2016
- Medium
- Build: staging
- Easy Test
- # 8199
- Diff
- FPerisa:issue_5563
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
A Solution for issue #5563
The issue:
Mobile users could have problems to use the form for searching tags and their articles, because it has no buttons.
My solution:
Like the issue maker wanted it, I added one button for entering the form field and one button for clearing the input of the field.
Testing instructions:
- Go to the searching form for tags "/all-tags"
- Without the patch you see only an input form field and you submit it with pushing enter
- With the patch you see nice new buttons
- Try them out!
- Do the same with the other form where you search the articles of one tag, e.g. "/all-tags/4-green"
Expected result:
Two new buttons can be used for submitting the form and clearing the input.
The clear button works only when the form got submitted once, because the form field submits immediately, when the user clicks out of it.
Worked as a group on that issue: @icampus @kathastaden @flow87 @xsability
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Accessibility Front End |
| Easy | No | ⇒ | Yes |
I have tested this item 
successfully on 44c43aa
I have tested and its a really cool thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8199.
| Status | Pending | ⇒ | Ready to Commit |
As we have two successful tests I am marking this RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8199.
| Labels |
Added:
?
|
||
@brianteeman. This PR usw hard coded strings and has merge conflicts ;)
The merge conflict appears to be the result of Franciska not rebasing after another of her PRs (#8040) was accepted into the master on the same code. The merge conflict is trivial and easily resolved at the time of merging.
Hardcoded strings would need correcting before this PR can be accepted.
Moving back to pending. Anyone care to help out? Franciska?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8199.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
Is there interest in an updated version of this PR? (staging...wojsmol:FPerisa-issue_5563)
@wojsmol as @FPerisa appears to have abandoned this then could you submit your patch as a new PR and I will close this here
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8199.
| Status | Pending | ⇒ | Information Required |
@brianteeman I will open PR today after work.
@FPerisa @brianteeman Please test #9899
Closing here
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-13 14:46:26 |
| Closed_By | ⇒ | brianteeman |
I have tested this item
successfully on 44c43aa
It's nice.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8199.