[#9877] - [Protostar] Add offline template as example
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- # 9877
- Diff
- andrepereiradasilva:protostar-offline-example
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
Add a default offline template for protostar to serve as an example.
Testing Instructions
- Use latest staging
- Install patch
- Play with offline options in global configuration and check the result in the frontend
- Test login and login errors
- Test also customizing protostar template
- Test also in mobile view
- Test also in a rtl language
Observations
If any frontend developer can review it, i'm open to any suggestions and/or improvements.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Templates (admin) |
and without this patch how does your offline page appears?
Screenshot without the patch - i dont remenber seeing the error before - must be getting old
so your problem is something else, not to do with this PR
doing a clean install now of latest staging
On 12 April 2016 at 22:20, andrepereiradasilva notifications@github.com
wrote:
so your problem is something else, not to do with this PR
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9877 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
i just tried yet again on latest staging, didn't get any issue
I have tested this item 
successfully on b8265f3
Must have been something wrong i my test install - all good now on latest staging
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9877.
I have tested this item successfully on b8265f3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9877.
This PR has received new commits.
CC: @brianteeman, @ghazal
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9877.
| Status | Pending | ⇒ | Ready to Commit |
Looks good to me - setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9877.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 06:12:17 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have an error on the page
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9877.