? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Apr 2016

Pull Request for Improvement.

Summary of Changes

Like done for so many other views across Joomla backend, this PR adds the search tools to com_messages messages view.
Also improved mobile view, added a "All" filter in the message state and some minor adjustements.

Before Patch

image

After Patch

image

Testing Instructions

  1. Apply patch
  2. Go to "Components" -> "Messaging"
  3. Send some Messages across users (you will need to create another user for that)
  4. Check if the searchtools, filters and ordering are working properly.
avatar andrepereiradasilva andrepereiradasilva - open - 12 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 12 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - test_item - 12 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 65cb116


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar brianteeman brianteeman - change - 12 Apr 2016
Labels
avatar brianteeman brianteeman - change - 12 Apr 2016
Category UI/UX
avatar brianteeman brianteeman - change - 12 Apr 2016
Category UI/UX Language & Strings UI/UX
avatar andrepereiradasilva andrepereiradasilva - change - 12 Apr 2016
Labels
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

done

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar brianteeman brianteeman - test_item - 12 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on dbafbcb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar MATsxm MATsxm - test_item - 12 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on dbafbcb

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

@brianteeman @MATsxm thanks for testing.

avatar brianteeman brianteeman - change - 12 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 12 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 12 Apr 2016

@andrepereiradasilva could you check the conflicts, thanks

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @brianteeman, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

ignore again the unit tests label, somehow my git changed the filename of the xcache unit test, i reverted. all good now and no conflicts.

avatar brianteeman brianteeman - change - 12 Apr 2016
Labels Removed: ?
avatar MATsxm MATsxm - test_item - 12 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 9330800

I don't know if it needs to be tested again but... it is!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9876.

avatar rdeutz rdeutz - reference | 52c4153 - 13 Apr 16
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar rdeutz rdeutz - close - 13 Apr 2016
avatar rdeutz rdeutz - change - 13 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-13 04:53:22
Closed_By rdeutz
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 13 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment