? ? Success
Referenced as Pull Request for: # 10186

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Apr 2016

Summary of Changes

Add ability to see sass files in the list of available files in the tree
Add ability to create a new file of type sass/scss
Add ability to open, edit and save a sass/scss file

Testing Instructions

Install patch and go to template manager and select a template (not a style)
Select New File from the toolbar
Create a new file and select sass from the file type dropdown
Check that file can be seen in the folder tree and can be selected, edited, saved and deleted

avatar brianteeman brianteeman - open - 12 Apr 2016
avatar brianteeman brianteeman - change - 12 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 Apr 2016
Category Templates (admin) Templates (site)
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Apr 2016 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Apr 2016

I have tested this item :red_circle: unsuccessfully on cb02eb7

File cannot be seen, but it exist. Cause make a new File with same Name and Place in Folder got Error

"File with the same name already exists. Failed to create file."

Test on Joomla! 3.5.2-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on cb02eb7

Works fine, but i need to many added 'sass' extension to templates "Options" to view the created file in the list os files.

After that i did:
1. Selected css dir
2. New file type 'sass' named 'template'
3. Created and can view and edit it.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

BTW you can also have scss file extensions? right?

SCSS is the new version of SASS, i think.
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#syntax

avatar brianteeman
brianteeman - comment - 12 Apr 2016

@andrepereiradasilva yes you can but its not as common

I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

@andrepereiradasilva yes you can but its not as common

Yes, but it seems in the new version, so if adding sass, shouldn't we also add scss?

I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options

i only see two ways: force updating the options parameters in the database on joomla update (IMO not B/C)... or adding a post install message to inform users of the change and what they need to do. I don't like neither. Most users don't even use this options. Is it worth it?

avatar brianteeman
brianteeman - comment - 12 Apr 2016

We could add scss no problem

I think the database update is what has been done before but I am not sure.
Maybe someone else knows. I definitely wouldnt go with the post-install
message

On 12 April 2016 at 17:29, andrepereiradasilva notifications@github.com
wrote:

@andrepereiradasilva https://github.com/andrepereiradasilva yes you can
but its not as common

Yes, but it seems in the new version, so if adding sass, shouldn't we also
add scss?

I think I see the problem you both had and I dont know how to fix it. I am
adding the file type sass in the options but its not seen until you open
and save the options

i only see two ways: force updating the options parameters in the database
on joomla update (IMO not B/C)... or adding a post install message to
inform users of the change and what they need to do. I don't like neither.
Most users don't even use this options. Is it worth it?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

We could add scss no problem

yes

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar brianteeman brianteeman - change - 12 Apr 2016
The description was changed
Title
Add basic support for sass files to Template manager editing
Add basic support for sass/scss files to Template manager editing
avatar brianteeman
brianteeman - comment - 12 Apr 2016

Updated to include scss files


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar brianteeman brianteeman - change - 12 Apr 2016
Title
Add basic support for sass files to Template manager editing
Add basic support for sass/scss files to Template manager editing
avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 5d83f8b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar zero-24
zero-24 - comment - 12 Apr 2016

@brianteeman i don't think we should overrwrite it with a db update as this can ause problems if somone has add / cahnge this setting bevor the update. (e.g. removed some extensions) if we include the db update we revert all changes he made.

So this one will be only for new installs.

The other way arround could be to analyse this setting during the update (script.php) and only add this two values in (if not set bevor) but leave the other one allown.

But i think this is to mich code for a that simple change and if someone is come up and wantbto use it there can be a document page that explains the place to add the extensions.

Another way arround could be a messagebif someone try to create a file with a extesion that is not in the allowed extension setting amd told the user "please add the extension to the settings" or something like that.

avatar zero-24
zero-24 - comment - 12 Apr 2016

The seccond option would also catch the case that somone manually removend some extensions form that list.

avatar brianteeman
brianteeman - comment - 12 Apr 2016

I agree with your assessment - any idea how to do the second option?

On 12 April 2016 at 18:13, zero-24 notifications@github.com wrote:

The seccond option would also catch the case that somone manually removend
some extensions form that list.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 12 Apr 2016

Please have a look at: brianteeman#9

avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 12 Apr 2016

I have merged the suggestion from @zero-24 please can you all test again


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar brianteeman
brianteeman - comment - 13 Apr 2016

I have merged @zero-24 latest correction

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 13 Apr 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on 2516589

Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got now Message why Files aren't shown.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar brianteeman
brianteeman - comment - 13 Apr 2016

And are they shown after you make the change from the message

On 13 April 2016 at 07:01, Franz Wohlkönig notifications@github.com wrote:

I have tested this item [image: :white_check_mark:] successfully on
2516589
2516589

Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got

now Message why Files aren't shown.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9871
https://issues.joomla.org/tracker/joomla-cms/9871.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Apr 2016

I thought its enough to know why the Files don't show. I don't know so i have to search how to "append the new File-Extensions in the List of supported Formats at the Template-Options".

avatar brianteeman
brianteeman - comment - 13 Apr 2016

On the main template manager screen select options from the toolbar in the top right.
Then add sass and scss to the list of Valid Source Formats
eg
txt,less,ini,xml,js,php,css,sass,scss

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Apr 2016

Thanks @brianteeman Yes, they are now shown.

avatar brianteeman
brianteeman - comment - 13 Apr 2016

Thanks for testing

On 13 April 2016 at 09:21, Franz Wohlkönig notifications@github.com wrote:

Thanks @brianteeman https://github.com/brianteeman Yes, they are now
shown.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

so what's needed to test now ?

avatar brianteeman
brianteeman - comment - 13 Apr 2016

@andrepereiradasilva as before but if after applying the patch you have not updated the list of allowed extensions in the options you will still be able to create a file but you cant see it and so a message will be displayed

avatar andrepereiradasilva andrepereiradasilva - test_item - 13 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on 2516589

I think what was left to test is the message when you don't have the filetype in the template config options.

If so, tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016

ok, just tested. :)

avatar brianteeman brianteeman - change - 13 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 13 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 27 Apr 2016
Category Templates (admin) Templates (site) Language & Strings Templates (admin) Templates (site)
avatar brianteeman brianteeman - change - 27 Apr 2016
Labels
avatar rdeutz
rdeutz - comment - 2 May 2016

@brianteeman cloud you please check the merge conflicts, thanks

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 May 2016

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.

avatar wojsmol
wojsmol - comment - 2 May 2016

@brianteeman Plese remove conficts markers

avatar brianteeman brianteeman - change - 2 May 2016
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 2 May 2016

Closed see #10186

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 May 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-05-02 09:29:06
Closed_By brianteeman
Labels
avatar brianteeman brianteeman - change - 2 May 2016
Labels
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Status Closed New
Closed_Date 2016-05-02 09:29:06
Closed_By brianteeman
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Status New Pending
avatar brianteeman brianteeman - close - 2 May 2016
avatar joomla-cms-bot joomla-cms-bot - reopen - 2 May 2016
avatar brianteeman brianteeman - change - 2 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-02 09:29:28
Closed_By brianteeman
avatar brianteeman brianteeman - close - 2 May 2016
avatar rdeutz rdeutz - change - 2 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment