User tests: Successful: Unsuccessful:
Add ability to see sass files in the list of available files in the tree
Add ability to create a new file of type sass/scss
Add ability to open, edit and save a sass/scss file
Install patch and go to template manager and select a template (not a style)
Select New File from the toolbar
Create a new file and select sass from the file type dropdown
Check that file can be seen in the folder tree and can be selected, edited, saved and deleted
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Templates (admin) Templates (site) |
I have tested this item successfully on cb02eb7
Works fine, but i need to many added 'sass' extension to templates "Options" to view the created file in the list os files.
After that i did:
1. Selected css dir
2. New file type 'sass' named 'template'
3. Created and can view and edit it.
BTW you can also have scss
file extensions? right?
SCSS is the new version of SASS, i think.
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#syntax
@andrepereiradasilva yes you can but its not as common
I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options
@andrepereiradasilva yes you can but its not as common
Yes, but it seems in the new version, so if adding sass, shouldn't we also add scss?
I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options
i only see two ways: force updating the options parameters in the database on joomla update (IMO not B/C)... or adding a post install message to inform users of the change and what they need to do. I don't like neither. Most users don't even use this options. Is it worth it?
We could add scss no problem
I think the database update is what has been done before but I am not sure.
Maybe someone else knows. I definitely wouldnt go with the post-install
message
On 12 April 2016 at 17:29, andrepereiradasilva notifications@github.com
wrote:
@andrepereiradasilva https://github.com/andrepereiradasilva yes you can
but its not as commonYes, but it seems in the new version, so if adding sass, shouldn't we also
add scss?I think I see the problem you both had and I dont know how to fix it. I am
adding the file type sass in the options but its not seen until you open
and save the optionsi only see two ways: force updating the options parameters in the database
on joomla update (IMO not B/C)... or adding a post install message to
inform users of the change and what they need to do. I don't like neither.
Most users don't even use this options. Is it worth it?—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9871 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
We could add scss no problem
yes
This PR has received new commits.
CC: @andrepereiradasilva, @franz-wohlkoenig
This PR has received new commits.
CC: @andrepereiradasilva, @franz-wohlkoenig
Title |
|
Updated to include scss files
Title |
|
I have tested this item successfully on 5d83f8b
@brianteeman i don't think we should overrwrite it with a db update as this can ause problems if somone has add / cahnge this setting bevor the update. (e.g. removed some extensions) if we include the db update we revert all changes he made.
So this one will be only for new installs.
The other way arround could be to analyse this setting during the update (script.php) and only add this two values in (if not set bevor) but leave the other one allown.
But i think this is to mich code for a that simple change and if someone is come up and wantbto use it there can be a document page that explains the place to add the extensions.
Another way arround could be a messagebif someone try to create a file with a extesion that is not in the allowed extension setting amd told the user "please add the extension to the settings" or something like that.
The seccond option would also catch the case that somone manually removend some extensions form that list.
I agree with your assessment - any idea how to do the second option?
On 12 April 2016 at 18:13, zero-24 notifications@github.com wrote:
The seccond option would also catch the case that somone manually removend
some extensions form that list.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Please have a look at: brianteeman#9
This PR has received new commits.
CC: @andrepereiradasilva, @franz-wohlkoenig
Labels |
Added:
?
|
I have merged the suggestion from @zero-24 please can you all test again
This PR has received new commits.
CC: @andrepereiradasilva, @franz-wohlkoenig
I have tested this item successfully on 2516589
Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got now Message why Files aren't shown.
And are they shown after you make the change from the message
On 13 April 2016 at 07:01, Franz Wohlkönig notifications@github.com wrote:
I have tested this item [image: ] successfully on
2516589
2516589Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got
now Message why Files aren't shown.
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9871
https://issues.joomla.org/tracker/joomla-cms/9871.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I thought its enough to know why the Files don't show. I don't know so i have to search how to "append the new File-Extensions in the List of supported Formats at the Template-Options".
On the main template manager screen select options from the toolbar in the top right.
Then add sass and scss to the list of Valid Source Formats
eg
txt,less,ini,xml,js,php,css,sass,scss
Thanks @brianteeman Yes, they are now shown.
Thanks for testing
On 13 April 2016 at 09:21, Franz Wohlkönig notifications@github.com wrote:
Thanks @brianteeman https://github.com/brianteeman Yes, they are now
shown.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
so what's needed to test now ?
@andrepereiradasilva as before but if after applying the patch you have not updated the list of allowed extensions in the options you will still be able to create a file but you cant see it and so a message will be displayed
I have tested this item successfully on 2516589
I think what was left to test is the message when you don't have the filetype in the template config options.
If so, tested successfully.
ok, just tested. :)
Status | Pending | ⇒ | Ready to Commit |
Labels |
Labels |
Added:
?
|
Milestone |
Added: |
Category | Templates (admin) Templates (site) | ⇒ | Language & Strings Templates (admin) Templates (site) |
Labels |
@brianteeman cloud you please check the merge conflicts, thanks
This PR has received new commits.
CC: @andrepereiradasilva, @franz-wohlkoenig
@brianteeman Plese remove conficts markers
Labels |
Removed:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 09:29:06 |
Closed_By | ⇒ | brianteeman | |
Labels |
Labels |
Status | Closed | ⇒ | New |
Closed_Date | 2016-05-02 09:29:06 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Pending |
Labels |
Removed:
?
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 09:29:28 |
Closed_By | ⇒ | brianteeman |
Milestone |
Removed: |
I have tested this item unsuccessfully on cb02eb7
File cannot be seen, but it exist. Cause make a new File with same Name and Place in Folder got Error
"File with the same name already exists. Failed to create file."
Test on Joomla! 3.5.2-dev
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.