Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10186] - Add basic support for sass/scss files to Template manager editing (redo)

? ? ? Pending
Pull Request for # 9871

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 May 2016

Redo to resolve merge conflicts in #9871

@zero-24 can you retest this please to make sure I didnt miss anything in this redo

avatar brianteeman brianteeman - open - 2 May 2016
avatar brianteeman brianteeman - change - 2 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 2 May 2016
The description was changed
Labels
avatar brianteeman brianteeman - change - 2 May 2016
Labels
avatar brianteeman brianteeman - change - 2 May 2016
Category ⇒ Components UI/UX
avatar brianteeman brianteeman - change - 2 May 2016
Rel_Number 0 ⇒ 9871
Relation Type ⇒ Pull Request for
Labels
avatar brianteeman brianteeman - change - 2 May 2016
Category Components UI/UX ⇒ Components Language & Strings UI/UX
avatar zero-24
zero-24 - comment - 2 May 2016

@brianteeman i have just send you a PR for travis i will try to test this evening.

avatar brianteeman brianteeman - change - 2 May 2016
Labels
avatar brianteeman brianteeman - reference | b4566f7 - 2 May 16
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 May 2016

travis still not happy

avatar brianteeman
brianteeman - comment - 2 May 2016

travis is happy now

avatar zero-24 zero-24 - test_item - 3 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 3 May 2016

I have tested this item :white_check_mark: successfully on 8f74e98

Works good! Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10186.

avatar brianteeman brianteeman - change - 3 May 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 3 May 2016

Moving to RTC as it was already tested before the redo for merge conflicts

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10186.

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 May 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 57025c3 - 3 May 16
avatar rdeutz rdeutz - merge - 3 May 2016
avatar rdeutz rdeutz - close - 3 May 2016
avatar rdeutz rdeutz - change - 3 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-03 09:32:53
Closed_By ⇒ rdeutz
avatar brianteeman brianteeman - head_ref_deleted - 3 May 2016
avatar brianteeman brianteeman - change - 9 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?
avatar DanGthatRokGallery DanGthatRokGallery - reference | 570e66e - 30 Aug 16
avatar C-Lodder
C-Lodder - comment - 2 Nov 2016

The SQL files also need updating too.

https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L506

"source_formats":"txt,less,ini,xml,js,php,css"

replace with:

"source_formats":"txt,less,ini,xml,js,php,css,sass,scss"

Unless this is done, people will manually need to go to the Template Options and manually add them.

Add a .scss or .sass to the Isis template directory and you'll notice it doesn't display the file when viewing the folder/files in the Template Manager.

avatar alikon alikon - reference | b667213 - 2 Nov 16
avatar zero-24
zero-24 - comment - 2 Nov 2016

Correct for 3.x we need to do this as we cant and should not override the entry in the database that maybe has ben changed to something different.

avatar zero-24
zero-24 - comment - 2 Nov 2016

Ahhh ok i got you point now. I'm on a PR :)

avatar alikon
alikon - comment - 2 Nov 2016

@zero-24 maybe this time more fast than you... bored on train....

avatar zero-24
zero-24 - comment - 2 Nov 2016

Thanks ?

Add a Comment

Login with GitHub to post a comment