? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 Apr 2016

Pull Request for Improvement.

Summary of Changes

This simple PR aggregates com_checkin and com_cache menu option in a "Maintenance" submenu,

Note the titles of the views already follow that logic.

image

image

image

Before PR

image

After PR

image

Testing Instructions

  1. Use latest staging
  2. Apply patch
  3. Check the "System" menu
avatar andrepereiradasilva andrepereiradasilva - open - 10 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ? ?
avatar MATsxm MATsxm - test_item - 10 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on 0cb62a2

Back to the 2.5's :smile:

Works as described - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9840.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

don't even remember how it was in 2.5.x :)

avatar brianteeman
brianteeman - comment - 10 Apr 2016

You forgot to check Hathor ;)

avatar brianteeman
brianteeman - comment - 10 Apr 2016

Joomla 2.5
7i65

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

if you want my honest opinion. i don't really like to make changes in hathor because IMHO is wasted time.

hathor can live perfectly good without the submenu ... hathor menus doesn't need to be like (and they aren't) isis menus.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

:smile: yes just like 2.5. IMO in this case the 2.5 way is better

avatar MATsxm
MATsxm - comment - 10 Apr 2016

@andrepereiradasilva
I would say that everyone agrees with your about Hathor but as long as we don't have a real admin template respecting the a11y basics, we will have to deal with it.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

and hathor with all the changes added still respects that a11y basics??

Anybody really tested?

avatar MATsxm
MATsxm - comment - 10 Apr 2016

Not what I said...
Just try to explain with my tarzan frenglish that as long as the goal of hathor was accessibility (not saying it reaches this goal) and as long as we have no other adequate response...
at least, that is what was explained to me :wink:

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

anyway, as i said this changes are not needed in hathor, as hathor doesn't have to add exactly the same menu as isis.

avatar andrepereiradasilva andrepereiradasilva - change - 10 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-10 20:36:41
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 10 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 Apr 2016
Status Closed New
Closed_Date 2016-04-10 20:36:41
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - change - 10 Apr 2016
Status New Pending
avatar andrepereiradasilva andrepereiradasilva - reopen - 10 Apr 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

sorry, wrong button...

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

FYI just checked the admin control panel in a auto accessibility WCAG 2.0 test tool:

  • Isis: 4 errors in WCAG 2.0
  • Hathor: 2 errors in WCAG 2.0

Note: i know there are also manual tests there should be made and all pages need to be checked. just to prove the point.

avatar MATsxm
MATsxm - comment - 10 Apr 2016

no need to proove something known...

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

Ok then.

avatar richard67 richard67 - test_item - 10 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on 0cb62a2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9840.

avatar brianteeman brianteeman - change - 11 Apr 2016
Category Administration Language & Strings Templates (admin) UI/UX
avatar brianteeman brianteeman - change - 11 Apr 2016
Labels
avatar brianteeman
brianteeman - comment - 11 Apr 2016

I am setting this to needs review so the maintainers can make a decision. I am assuming that there was a reason the behaviour changed from 2.5 and also a decision about it not being applied to hathor


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9840.

avatar brianteeman brianteeman - change - 11 Apr 2016
Status Pending Needs Review
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

is there a label "Needs review" to more clearly identity the PR that needs review by a mantainer so they don't go inside the black hole?

avatar brianteeman
brianteeman - comment - 12 Apr 2016

Right now the Needs Review is only in the issue tracker not github. (I will ask and see what they think about adding it on github as well.)

During the sprint next month I will be forcing the plt members there to make a decision on all the needs review issues ;)

avatar wilsonge
wilsonge - comment - 12 Apr 2016

gulp

avatar brianteeman
brianteeman - comment - 12 Apr 2016

I can add the label on github and manually update those issues there as well (if you want)

avatar wilsonge
wilsonge - comment - 12 Apr 2016

Ok I have no clue what the original intention was by the UX team in 3.x - but in my opinion less clicks (i.e. submenu's) is better. So I'd rather keep what we have and amend the language strings to be honest!

This kinda makes the hathor question redundant. But my opinion there is that Hathor is a separate template with different styling so it doesn't have to visually be exactly in sync with ISIS, however it does need to work..... so whatever makes sense - in this case I'd probably have applied it there as it's dead simple and it's easier to maintain them in parallel. But it doesn't mean as a rule of thumb every single change to ISIS must be applied to Hathor.

avatar wilsonge wilsonge - change - 12 Apr 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-04-12 22:13:47
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

ok so this is a no go. fine.

avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016

Add a Comment

Login with GitHub to post a comment