? ? Pending

User tests: Successful: Unsuccessful:

avatar stutteringp0et
stutteringp0et
10 Apr 2016

Pull Request for Issue # .

Summary of Changes

in line 1314 ��"$this->class->setHeader('foo', 'car');", the method is called without the $replace argument, meaning it uses the default of "false".

The way headers are set, allowing a duplicate here means the header is replaced in JApplicationWeb::header. If $replace isn't enforced in setHeader then duplicates mean the header gets replaced anyway.

The attempted entry is removed from the assertEquals test.

This change is in conjunction with a JApplicationWeb PR I have waiting
#9836

in line 1314 ��"$this->class->setHeader('foo', 'car');", the method is called without the $replace argument, meaning it uses the default of "false".

The way headers are set, allowing a duplicate here means the header is replaced in JApplicationWeb::header. If $replace isn't enforced in setHeader then duplicates mean the header gets replaced anyway.

The attempted entry is removed from the assertEquals test.

This change is in conjunction with a JApplicationWeb PR I have waiting
#9836

Testing Instructions

avatar stutteringp0et stutteringp0et - open - 10 Apr 2016
avatar stutteringp0et stutteringp0et - change - 10 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ? ?
avatar stutteringp0et stutteringp0et - change - 10 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-10 19:23:42
Closed_By stutteringp0et

Add a Comment

Login with GitHub to post a comment