[#9835] - Solves inconsistency with en-GB language package
- Fixed in Code Base
- 8 May 2016
- Medium
- Build: staging
- # 9835
- Diff
- andrepereiradasilva:en-gb-language-package-consis
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
As detected in PR #9744, there is an inconsistency in the en-GB language extensions.
The default language (en-GB) should have 3 extensions like any other language pack:
1. type = language | client = Site: For the site site language
2. type = language | client = Administrator: For the administrator site language
3. type = package | client = Site: For the whole en-GB language package
But, only extensions "1." (en-GB site language) and "2." (en-GB admin language) exist in Joomla core default database.
The extension "3." (pkg_en-GB language package), although it has a manifest file, doesn't have an extension in Joomla core default database.
Note that this is the only manifest file in the whole Joomla core that doesn't has an extension in the database, and for consistency it should.
This generates some inconsistencies, for instance the update server is declared in the extension "3." (en-GB language package) manifest file, but in the database is linked to extension "1." (en-GB site language).
Extension "1." (en-GB site language) doesn't have update servers in his manifest file, because is a extension of language type.
So, this PR adds the "pkg_en-GB language package" extension to new joomla installation, also adds it to the upgrade process and makes the necessary adjustments in the code.
Testing Instructions
New installation
- Install Joomla with this package https://github.com/andrepereiradasilva/joomla-cms/archive/en-gb-language-package-consis.zip
- Add some languages in the end of the installation. Check if they are installed correctly.
- Go to admin. "Extensions -> Manage -> Install languages"
- Install some languages. Check if everything is fine
- Go to "Extensions -> Manage -> Update Sites" and check if all "Accredited Joomla! Translations" are o the type "Package", including the en-GB one.
- Go to "Extensions -> Manage -> Manage", filter by package and check if and languages are there. Including the en-GB (should be blocked).
Upgrade
- Use 3.5.1 or latest staging
- Install patch #9612 with patchtester so you can update joomla with upload method
- Go to Joomla update component
- Update joomla with this custom 3.5.5 package https://github.com/andrepereiradasilva/update.joomla.org/raw/master/Joomla_3.5.1_to_3.5.5-Stable-Patch_Package.zip
- Repeat the same steps "3." to "6." of the "New installation" test.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
That would be wrong because the language pack isn't updated on its own. It's part of the core.
The manifest files (and especially the package one) for en-GB are mainly present to allow translation using Crowdin (or other tools). They aren't used actively in the CMS and shouldnt be used.
Since you can't (and shouldn't) uninstall en-GB anyway, there is no reason to register it as a package.
because the language pack isn't updated on its own. It's part of the core.
Yes, as most of the extensions that exist by default in the extensions table...
The manifest files (and especially the package one) for en-GB are mainly present to allow translation using Crowdin (or other tools). They aren't used actively in the CMS and shouldnt be used.
Since you can't (and shouldn't) uninstall en-GB anyway, there is no reason to register it as a package.
I disagree, is a matter of consistency, all core joomla extensions are in the database.
Remember, the pkg_en-GB extension is blocked so it can't be uninstalled like all the other ones that are joomla core extensions.
I understand both arguments and personally agree with @andrepereiradasilva but setting to Needs Review so PLT can make a definitive decision
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9835.
| Status | Pending | ⇒ | Needs Review |
| Status | Needs Review | ⇒ | Information Required |
@andrepereiradasilva Can you please update this PR so that the SQL files are numbered 3.6.0? After that we can merge this. Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9835.
| Status | Information Required | ⇒ | Pending |
Do we not need a manifest file as well to go here: https://github.com/joomla/joomla-cms/tree/staging/administrator/manifests/packages
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 14:16:00 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
Merged
ok, now it uses the 801 id for the pkg_en-GB extension