Post to joomla-projects/help-proxy please. These aren't coming from core.

On Sunday, April 10, 2016, Brian Teeman notifications@github.com wrote:

A lot of the help screens accessed from the Joomla admin display the words
< translate> and </ translate> repeatedly throughout the content

[image: screen shot 2016-04-10 at 10 59 43]
https://camo.githubusercontent.com/a4492417b6a7524b7e0ffff2013ee34bba17e230/68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f34373939666537393662326533306535313537346530336630633262616166352e706e67

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#9834

we are worjing on it as those pages needs to be tagged/marked for translation manually

FYI - Still in progress

Ok, finally and at this point only for articles under ALPHABETICAL ORDER, the issue about the appearance of the <translate> tags should be fixed.
Thank you to tell me if I missed some.

FYI, this could still happen on other few HelpScreens and will be fixed during next months.
The content (text and screenshots), dead links (red links) will be done later.

<translate> tags for the main articles should be fixed now then this one can be closed.
Thanks

You know we can just filter them out in the code, right?

Someone who speaks better regex than me can do that, just need it added to https://github.com/joomla-projects/help-proxy/blob/master/com_help/site/helpers/help.php and if a new method is added ensure the model calls it.

@chrisdavenport..... no I don't
@mbabker yeah sure

This is because it's still not pulling from the language code from a translated page. If j is en-GB then it should add /en at the end of the url. If /en page 404's then default to no Lang code on end. The same would apply to any four letter language code used by Joomla. fr-FR would ask for /fr. 404 then ask for /en or no Lang code end.

In any regard I suppose could regex out the tags and make no code (English) the default fallback.

The lang code isn't getting plugged onto the URL when the request to the docs wiki is getting made (it is sent to the help proxy, just not from there to Mediawiki). It actually has the error check in place to deal with a 404 for non-translated. So, I just need to know what to plug onto the URL and where and wham, language context is taken into account.

Wham? https://www.youtube.com/watch?v=JX_zmcVE0Wc

On 20 April 2016 at 22:27, Michael Babker notifications@github.com wrote:

The lang code isn't getting plugged onto the URL when the request to the
docs wiki is getting made (it is sent to the help proxy, just not from
there to Mediawiki). It actually has the error check in place to deal with
a 404 for non-translated. So, I just need to know what to plug onto the URL
and where and wham, language context is taken into account.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9834 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

It's tacked onto the end of the page name.

Help35:Pagename/en

Although I did write a REGEX about an hour ago to deal with the translate tags and <!--T:##--> if it defaults back to the pure English version without the /en

And how do you do that through the API? https://docs.joomla.org/index.php?action=render&title=Help35:Components_Content_Categories_Edit is the URL format we're using on the proxy.

Nevermind, the same /lang works there too.

Bingo. Technically that's not really the API remember we cheated

OK, proxy's updated to process the language code now.

I pushed a patch to REGEX out the translation stuff if you want to be extra
cautious. The issue I can see is a page translated to fr-FR for example,
but not another language. If say /es is empty it defaults back to the main
page, not the Pagename/en then they would see the tags again.

It is possible pages are translated, but not to all languages. eg, some
pages in help are translated in Russian, but not all of them.

On Wed, Apr 20, 2016 at 8:42 PM, Michael Babker notifications@github.com
wrote:

OK, proxy's updated to process the language code now.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9834 (comment)

Tom Hutchison

Closed