[#9826] - [imp] Adding a short link readonly field in menu item edit
- Closed
- 7 May 2016
- Medium
- Build: staging
- # 9826
- Diff
- infograf768:menuitem_shortlink
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When using a Login menu item, one has to enter an internal URL for the login and logout redirections as the fields are of type text instead of menuitem.
Most often, one needs to redirect to an existing menu item.
This new field in the menu item edit will display the correct short url to copy/paste.
It also may be of use for 3rd party extensions.
Just an info, but a useful one. Works also on a multilingual site by adding the correct lang.
Evidently, this shortlink has to be passed through a JRoute() to be used as should on the site.
This is the case for the Login menu item redirections.
After patch:
Example of use in a Login Menu item:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
You are saying that the short link is index.php?Itemid=280 but isnt the correct link index.php?option=com_content&view=article&id-53&Itemid=280
As the title says, "index.php?Itemid=280" can replace easily the detailed link. Just test for yourself.
Wouldnt it be better all round to make the login redirect a select box like it is in the module
That is an issue and the reason for this PR (as well as for #9724). As it is now it would not be B/C as it is a full link which is saved in the params and not only an itemid.
While it seems to work, i don't particularly agree with this change.
For me a shortlink is something like https://site.tld/<id-or-some-chars> that is a link for communication purposes or even for micro bloging plataforms (ex: twitter).
Wouldnt it be better all round to make the login redirect a select box like it is in the module
I think so, but it seems can be B/C issues
We can evidently replace the word "Short Link" by anything else. But it is this format which is useful.
"Short Internal Link" ?
why not just use a placeholder="index.php?Itemid=<menu-id>&lang=<language-tag>" in the login/logout redirect field as a example?
More simpler and less confusing IMHO
we do not want the &lang=<language-tag> for a non multilingual site.
I just proposed this PR to help users. I can live without it.
The best solution that would be B/C is to propose 2 fields in the login menu and force one only to be used, then modify the code to fit depending if it's an itemid or another internal link used.
yes, i understand that, i'm just saying that in my opinion it can be have the opposite effect and confuse users more.
Why not just add the itemid onto the existing Link field? I never understood why it wasnt there anyway
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9826.
@brianteeman
It would not help in the multilingual case. But we could add also the lang if in multilingual.
That would not help much in #9724 as the ideal for the login menu item redirection is definitely an itemid.
I will try to work on the double field idea.
| Category | ⇒ | Administration Language & Strings |
| Labels | |||
Setting to Needs Review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9826.
| Status | Pending | ⇒ | Needs Review |
| Status | Needs Review | ⇒ | Pending |
@infograf768 I agree with this change but as @brianteeman pointed out we should be using the existing link field. Can you provide an update on this?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9826.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 11:43:15 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
You are saying that the short link is index.php?Itemid=280 but isnt the correct link index.php?option=com_content&view=article&id-53&Itemid=280
Wouldnt it be better all round to make the login redirect a select box like it is in the module
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9826.