? Failure

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Apr 2016

Summary of Changes

Remove the extra spaces before the links

Before " View site"

After "View site"

Testing Instructions

Apply the patch and check that there are no leading spaces on any of the links in the admin status module at the bottom

avatar brianteeman brianteeman - open - 10 Apr 2016
avatar brianteeman brianteeman - change - 10 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 10 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on 0dffcbc

Tested by code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar brianteeman brianteeman - change - 10 Apr 2016
Easy No Yes
avatar brianteeman brianteeman - change - 10 Apr 2016
Category Modules Templates (admin)
avatar andrepereiradasilva andrepereiradasilva - test_item - 10 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on b37801c

Was about to comment about of the space in the multilingual link.

I see you solve it.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

While you're at it, just to inform when you add a new module there's extra spaces in the links to. For another PR of course.
image

avatar brianteeman
brianteeman - comment - 10 Apr 2016

Yes another PR which I will look at now

avatar MATsxm MATsxm - test_item - 10 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on b37801c

the most obvious is what we don't see - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar brianteeman brianteeman - change - 10 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 10 Apr 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 10 Apr 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Apr 2016

This PR has received new commits.

CC: @andrepereiradasilva, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9825.

avatar wilsonge wilsonge - change - 10 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-10 14:54:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Apr 2016
avatar wilsonge wilsonge - merge - 10 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 10 Apr 2016
avatar wilsonge wilsonge - reference | 630c5fa - 10 Apr 16
avatar wilsonge wilsonge - merge - 10 Apr 2016
avatar wilsonge wilsonge - close - 10 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 10 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment