Hi andrepereiradasilva,
Under your "Do the test" instruction in point 2nd, after clicking "test-article-1" link the edit option is available on that page after clicking, I think there is no point in going back as per your instruction.

And after that i followed:
1. test-article-1 link: http://localhost/stagingtest/index.php/test-article-menu
2. clicking on test-article-1 edit link: http://localhost/stagingtest/index.php/test-article-menu?view=form&layout=edit&a_id=6&return=aHR0cDovL2xvY2FsaG9zdC9zdGFnaW5ndGVzdC9pbmRleC5waHAvdGVzdC1hcnRpY2xlLW1lbnU=

Without applying patch they show test-article-menu.

Tell me if i have missed something, so that i can test again.

Before patch did you check the links on the frontpage as image above?

• Article link: http://yourhostname/test-article-menu
• Article edit link: http://yourhostname/?task=article.edit&a_id=5&return=<hash>

Under your "Do the test" instruction in point 2nd, after clicking "test-article-1" link the edit option is available on that page after clicking, I think there is no point in going back as per your instruction.

That's exactly the point of this PR! The frontpage edit icons URI are different that the article page edit icons URI.

Yeah i checked before applying PR.
1. test-article-1 link: http://localhost/stagingtest/index.php/test-article-menu

1. clicking on test-article-1 edit link: http://localhost/stagingtest/index.php/test-article-menu?view=form&layout=edit&a_id=6&return=aHR0cDovL2xvY2FsaG9zdC9zdGFnaW5ndGVzdC9pbmRleC5waHAvdGVzdC1hcnRpY2xlLW1lbnU=

These are the results.

but did you click on "Edit" exactly when you're on the frontpage like the picture shows? Not inside the article page, that one is already fine without the PR.

This is how it looks on myside!!

I probably went to test-article-menu from homepage.Thats why it's not showing

you are not on the homepage ...
Look at the breadcrumb:

• mine "You are here: Home"
• yours: "You are here: Home > test-article-menu"

You must be on "Home"

test-home-menu should be the site default (home) page also

Yeah ,Mistake on my side.
Now it shows correctly after applying the patch and before applying it.

I have tested this item successfully on ea27c49

thanks for testing

I have tested this item unsuccessfully on ea27c49

... when clicking from home i have also the test-article-menu instead of the home item?

@designbengel
i don't understand what you mean. please be more specific.

If you're talking about the article edit link in featured articles in homepage, that's exactly the point of this PR, if you edit an article you should enter the edit layout in the article view not in the home page view.

Not sure this patch is necessary as it is not recorded by search engines. But it works fine.

While testing I remarked something which is weird:
When saving/canceling the edited article from the article view (not from the home featured page) the redirect url includes ?hitcount=0
I.e
domain.com/test-article-menu.html?hitcount=0

I have tested this item successfully on ea27c49

tested again and:
before applying the patch i have: index.php?view=form&layout=edit&a_id=77&return=xyz
after applying the patch i have: test-article-menu-99?view=form&layout=edit&a_id=77&return=xyz on home-item and on home-item-article

when there is no article menu item:
clicking on "All Front End Views" > "Featured Articles"
/index.php/featured-articles -> on edit the first article: index.php/article-category-list?view=form&layout=edit&a_id=24&catid=19&return=a

• when creating a single article menu item for this article it works like described.

is this right?

@designbengel.

There are 3 scenarios:

• If you DON'T HAVE a published menu item for the article and DON'T HAVE a published menu item for the article parent category: ContentHelperRoute::getArticleRoute will generate a custom URI for the article inside the category (ex: /8-category-en-gb/1-article-en-gb?task=article.edit&...), but when you click on it the edit mode is rendered in the frontpage.

• If you DON'T HAVE a published menu item for the article and HAVE a published menu item for the article parent category: ContentHelperRoute::getArticleRoute will generate a custom URI for the article inside the category (ex: /category-menu-item/1-article-en-gb?task=article.edit&...), and when you click on it the edit mode is rendered in article view.

• If you HAVE a published menu item for the article: ContentHelperRoute::getArticleRoute will generate a custom URI for the article (ex: /article-menu-item?task=article.edit&...), and when you click on it the edit mode is rendered in article view.

The second scenario seems to be your case.

But the point is, in any of the scenarios, when you mouseover the article URI and the "Edit" URI, the URI are exactly the same after this PR (excluding the edit URI parameters of course.)

So yes, IMO your test is a success.

@designbengel if it's a success test please mark it as success. thanks

I have tested this item successfully on ea27c49

RTC - maintainer please decide if this is a new feature or a bug fix

@shubhamnba2009 @designbengel @infograf768 thanks for testing.

for me it sounds more like a bug fix then a feature

ok 3.5.2 then

On 15 April 2016 at 13:11, Robert Deutz notifications@github.com wrote:

for me it sounds more like a bug fix then a feature

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9740 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/