[#969] - Adding loadByPsr0 to JLoader
- Closed
- 1 Jun 2013
- Medium
- Build: master
- # 969
- Diff
- dongilbert:psr0
- Foreign ID 30525
User tests: Successful: Unsuccessful:
This PR adds the ability for developers to integrate PSR-0 compatible code into their applications, such as that from the new Joomla Framework, and allow it to be registered properly to the autoloader.
Tracker item for this is here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30525
+1
I'll add some documentation for this as well. The usage is slightly different from what we are used to with JLoader.
Should probably add some test cases as well.
+1 from me too.
Excelent!!!
Thanks a lot @dongilbert ^_^
Don - Now that we're unit testing JLoader in the CMS, would you mind writing test cases for this loader (and possibly the other namespace loaders) so we make sure the CMS doesn't accidentally break this in the future?
I can write them up for this method, sure.
Florian had written the UT's for the other namespace loaders. However, I don't think we should keep them around, it was a mistake, IMO, to do it that way. Sure, it keeps it flexible, but it also keeps it complicated. I wonder if we could / should remove them. (I realize the viewpoint of the previous maintainers was a bit different.)
If the Joomla "standard" autoloader and the PSR-0 autoloader are all we really need in the CMS, I have no issue backing out the other stuff. We've been doing a lot of re-syncing between the CMS and Platform repos over the last few weeks, JLoader was just one of those classes that was synced in full. We're at a point where we can put some thought into what parts of the Platform we want to keep in the CMS and what should just disappear. For the NS loaders, that decision needs to come quick though; if 3.1.2 is released with them, we're stuck until 4.0.
Then let's please remove them.
I'll add it to the to-do list for when I get off work unless I'm beaten to the punch.
The Joomla "standard", PSR-0, and the soon to be ratified PSR-X will, in my opinion, meet all the needs of the CMS and it's developers.
I've dropped out the namespace loaders and provisioned the PSR-0 autoloader into JLoader::setup() (disabled by default for the time being).
+1