? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Mar 2016

Pull Request for Issue #9653

This PR implements the default selector advancedSelect for mod_languages module and smartsearch (module and component view).

This will avoid displaying as chosen every Select on a page not using chosen.

Testing Instructions

Install a simple multilang site.
Display a Language switcher for each language: one using dropdown, the other using flags.
Create a Smartsearch module. Set the parameters to Show "Advanced Search".
First unpublish it.

Patch.

Modify ROOT/components/com_content/views/form/tmpl/edit.php, i.e. comment
//JHtml::_('formbehavior.chosen', 'select');

Login frontend as Super Admin and edit an article in the language for which the switcher is set to dropdown.
The Select boxes in the Publishing tab are not using Chosen. The dropdown for mod_languages is.

screen shot 2016-03-30 at 16 32 46

Publish the SmartSearch Module, switch the language to the one using flags in the Switcher.

Edit again an article.
The smart Advanced Search dropdowns use chosen while the article Select Boxes don't.

avatar infograf768 infograf768 - open - 30 Mar 2016
avatar infograf768 infograf768 - change - 30 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
12edab7 30 Mar 2016 avatar infograf768 cs
avatar Bakual
Bakual - comment - 30 Mar 2016

Review is fine, and it's good practice to do like this and not using "select" as the operator. :+1:

avatar brianteeman brianteeman - change - 30 Mar 2016
Category Modules Templates (site)
avatar andrepereiradasilva andrepereiradasilva - test_item - 30 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on 12edab7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9671.

avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 30 Mar 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9671.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Milestone Added:
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 20:10:33
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar rdeutz rdeutz - reference | ad74f03 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar infograf768 infograf768 - head_ref_deleted - 17 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment