[#9669] - Disable SMTP auto TLS during mailer creation
- Closed
- 30 Mar 2016
- Medium
- Build: staging
- # 9669
- Diff
- piotrmocko:patch-25
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9373 .
Summary of Changes
Force to disable SMTP auto TLS if SMTP security is set to "none" in Joomla Global configuration.
It is farther improvement of PR #9528
Testing Instructions
- Setup mailer to SMTP
- Set SMTP port: 587
- Set SMTP security: none
- Set some SMTP username and password
- Set SMTP host, in my case it was 127.0.0.1
- Try to send email, you will get error message "SMTP connect() failed. https://github.com/PHPMailer/PHPMailer/wiki/Troubleshooting"
In my case I am connecting with SMTP over localhost on port 587, but I do no need to use any security like TLS or SSL, but PHPMailer forces to verify TLS.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
don't have a non tls mail server to test the change, but by code review it seems fine and makes sense.
brianteeman
- | Category | ⇒ | Libraries |
This is the whole point of the opportunistic detection.
It doesn't always try and connect with TLS - but it must think that your server supports it based on this call https://github.com/joomla/joomla-cms/blob/3.5.0/libraries/vendor/phpmailer/phpmailer/class.phpmailer.php#L1591 . We need to encourage servers to set up their SMTP servers properly (and if they are properly configured contribute fixes back to phpmailer) and I'm happy that even without this patch current staging will send emails properly - even if it does have to try twice...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-30 15:25:48 |
| Closed_By | ⇒ | wilsonge |
Now "SMTP security" option is misleading - "none" means that it will try to use TLS.
When I know that my server does not support TLS on localhost connection, then there is no need to make two attempts to connect and waist time.
Maybe it would be better to add 4th option: "Detect TLS" or something similar.
Or if you want to force all users, who had set "none" already, to detect TLS, then add 4th option "disable"
Maybe it would be better to add 4th option: "Detect TLS" or something similar.
Or "auto" 
I have tested this item
successfully on e17fc2e
Looks great. It makes no sense to set / test
SMTPAutoTLSif we set SMTP security tononeThis comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9669.