? ? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
30 Mar 2016

Summary of Changes

This expands the existing showon feature to fieldsets (tabs) in component options. This may for example be used by components if they want to show advanced options when a specific parameter is toggled.

Testing Instructions

Add a showon attribute (see https://docs.joomla.org/Form_field#Showon) to a fieldset in a components config.xml. Example in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/config.xml#L298
Change

    <fieldset name="editinglayout" label="COM_CONTENT_EDITING_LAYOUT"
                description="COM_CONTENT_CONFIG_EDITOR_LAYOUT">

to

    <fieldset name="editinglayout" label="COM_CONTENT_EDITING_LAYOUT"
                description="COM_CONTENT_CONFIG_EDITOR_LAYOUT"
                showon="show_title:1">

Then test if the fieldsets shows/hides when the chosen parameter is toggled.
In the example given the "Show Title" parameter in the com_content options would toggle the "Editing Layout" tab.

Note

This only affects component options. If someone knows how to do it for module, template and plugin options feel free to create a PR either against this one or as an own one. I tried with the module but couldn't figure it out yet.

avatar Bakual Bakual - open - 30 Mar 2016
avatar Bakual Bakual - change - 30 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Category Fields
avatar ahvink
ahvink - comment - 31 Mar 2016

Works like expected here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar brianteeman brianteeman - test_item - 31 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Mar 2016

I have tested this item :white_check_mark: successfully on 771d5c6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar brianteeman
brianteeman - comment - 31 Mar 2016

As we discussed the other week by email this a really useful change - THANKS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar brianteeman
brianteeman - comment - 31 Mar 2016

As we discussed the other week by email this a really useful change - THANKS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

@ahvink please mark as "Tested successfully" in "Joomla! Issue Tracker" https://issues.joomla.org/tracker/joomla-cms/9668 (after login the "Test this" button appears).
For more information see https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

avatar ahvink ahvink - test_item - 31 Mar 2016 - Tested successfully
avatar ahvink
ahvink - comment - 31 Mar 2016

I have tested this item :white_check_mark: successfully on 771d5c6

Great addition, works as expected!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar brianteeman brianteeman - change - 31 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 31 Mar 2016

Setting RTc - maintainer will need to decide when it should be merged


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9668.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2016
Labels Added: ?
avatar N6REJ
N6REJ - comment - 1 Apr 2016

very glad to see our discussion came to fruition so quickly.
Bear

On 3/31/2016 06:03, Brian Teeman wrote:

Setting RTc - maintainer will need to decide when it should be merged


_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9668
https://issues.joomla.org/tracker/joomla-cms/9668.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#9668 (comment)

avatar rdeutz rdeutz - change - 13 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 2 May 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 2 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-02 06:06:40
Closed_By rdeutz
avatar rdeutz rdeutz - close - 2 May 2016
avatar rdeutz rdeutz - merge - 2 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 2 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment