[#9662] - Update extensionupdatecheck.js
- Closed
- 8 May 2016
- Medium
- Build: staging
- # 9662
- Diff
- jochendaum:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9661 .
Summary of Changes
Simplify HTML/CSS created inside JavaScript file. span6 not required for 2nd alert.
Testing Instructions
Steps to reproduce the issue
download and install Joomla < 3.5.0
install not-up-to-date extension, ensure extension has auto-updater active
login to Administrator backend
Expected result
After a couple of seconds you would be notified about a Joomla upgrade and Extension upgrades being available. These notifications would be best displayed below each other:
This is common UX
If the alert boxes are of different height due to screen resolution, they appear misaligned
There should also be visual space between the alert boxes to distinguish them. The space should be of a common "width" as used elsewhere in the control panel
Actual result
The boxes are beside each other in resolutions wider than 1200px
The boxes have no space between them
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 9661 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Templates (admin) UI/UX |
| Category | Templates (admin) UI/UX | ⇒ | JavaScript Templates (admin) UI/UX |
| Status | Pending | ⇒ | Information Required |
Hi Brian, sorry my pull request was incomplete. I have added another change to it.
Once checks have run, you should see the changes as per the attached
before.png and after.png
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-02 19:46:18 |
| Closed_By | ⇒ | jochendaum |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-04-02 19:46:18 | ⇒ | |
| Closed_By | jochendaum | ⇒ |
| Status | New | ⇒ | Pending |
Do you really think that makes a difference?
On 2 April 2016 at 21:46, Jochen Daum notifications@github.com wrote:
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9662 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Well, this is my first pull request, so I did not want to make a huge change.
It has been an eyesore for at least 2 years personally for me.
On a factual basis, yes, I think it makes a difference and it also removes 10 lines of code, so that must be worth something.
The change would be more complete for me if it made sure that the Joomla update warning (if existing) is always at the top, as I think it should be shown as more important.
I have tested this item 
successfully on ea119c7
It does what it says but personally speaking I find it much uglier especially as the buttons are not aligned
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9662.
I'll have a think about that, and will have a look for UX guidelines that may match the scenario.
I have tested this item successfully on ea119c7
Works. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9662.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thank you @jochendaum and testers!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 13:10:37 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
roland-d
-
Please can you supply some screenshots of what changes I should be seeing. I have tried to test this and I just dont see any change at all
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9662.