[#9648] - Allow using underscore character in permission name
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9648
- Diff
- joomdonation:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9645 .
Summary of Changes
This PR fix an issue causes by some changes in saving permissions in Joomla 3.5.0. In older version of Joomla, we are allowed to use underscore character in permission name. From 3.5.0, if we use underscore character, the permission won't be saved properly. Please see #9645 to understand the issue
Testing Instructions
Open the file administrator/components/com_content/access.xml
Add a new permission which has underscore character (for example content.view_content) to component section. Example:
<action name="content.view_content" title="View Content" description="Allows viewing articles" />Go to System -> Global Configuration, select Articles component, Permissions tab (http://localhost/joomla35/administrator/index.php?option=com_config&view=component&component=com_content).
Try to change permission for View Content permission
Before this patch, you could not change setting for the new permission you just added
After this patch, the change you made for the new permission can be saved
Try to change other permission and make sure it is saved properly
Hopefully, this issue can be fixed and go to 3.5.1
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | ACL JavaScript |
| Rel_Number | 0 | ⇒ | 9645 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item 
successfully on 8eb9577
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9648.
Thanks @brianteeman for confirming the issue and testing the PR. I updated the PR with clear instruction so that testers won't have to look at the issue for testing instruction
Could we please have one more tester so that this one can be merged? It would be nice to have this fixed in Joomla 3.5.1
I have tested this item successfully on 8eb9577
Able to reproduce and #9648 works as described as now the changes for permission are well saved.
Also thanks for the step by step testing instructions.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9648.
It's unfortunately too late for 3.5.1
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
OK. I was hoping it could go into 3.5.1. However, as this PR is RTC now, I think I can ship these modified files with my extensions and overwrite the old files on my customer's websites
Thanks again.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 20:03:14 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Testers dont forget to clear your browser cache after applying this Pr
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9648.