Feeling Lucky
?
[#9637] - Frontend com_modules fixes (Ref #9629)
- Fixed in Code Base
- 28 Mar 2016
- Medium
- Build: staging
- # 9637
- Diff
- mbabker:modules-edit-fixes
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9629.
Summary of Changes
The com_modules admin view that the toolbar button loads is missing several checks for this function, to include:
- An instruction to not load the toolbar for the modal view causing the
JToolbarHelpernot found error - Missing CSRF token check (it's passed in the URL but the layout never made the check)
Testing Instructions
Apply the patch and the module toolbar button should correctly work on the frontend
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
andrepereiradasilva
- comment
- 28 Mar 2016
I have tested this item 
successfully on 8b0f5ac
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9637.
MATsxm
- comment
- 28 Mar 2016
I have tested this item successfully on 8b0f5ac
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9637.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 28 Mar 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-28 19:34:26 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
wilsonge
- comment
- 28 Mar 2016
Merged - thanks guys!
I have tested this item
successfully on 8b0f5ac
The module option when selected in frontend article edit view is not showing any further errors.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9637.