? Pending

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
28 Mar 2016

The new TinyMCE in Joomla 3.5 has a serious issue.
When an editor button uses a name that is also used by TinyMCE's own buttons, it doesn't get placed at all.
For instance, a button using the title "Fun", "Form" or "Tools" will not show.
A button using the name "Container" will even cause a javascript error.

Also it isn't possible to place multiple buttons with the same title.
For instance, placing 2 buttons with the title 'My Button' will only place the first.

This PR fixes the issue, by simply prepending the name (used in javascript only) with button- and the count number of the button.
This makes the buttons unique.

Testing instructions

Test by changing the title ($button->text) of for instance the core Read More button to "Fun".
You can do that via the language overrides or directly in the php code of:
plugins/editors-xtd/readmore/readmore.php

$button->text = 'Fun';

The titles that cause issues:
AbsoluteLayout, AddOnManager, Arr, Binding, BlobCache, BookmarkManager, BoxUtils, Button, ButtonGroup, CaretBookmark, CaretCandidate, CaretContainer, CaretPosition, CaretUtils, CaretWalker, Checkbox, Class, ClassList, ClientRect, Collection, Color, ColorBox, ColorButton, ColorPicker, ComboBox, Compat, Container, Control, ControlSelection, Conversions, Delay, Dimensions, DomParser, DomQuery, DOMUtils, DomUtils, DragDropOverrides, DragHelper, Editor, EditorCommands, EditorManager, EditorObservable, EditorUpload, ElementPath, ElementUtils, EnterKey, Entities, Env, EventDispatcher, EventUtils, ExtendingChar, Factory, FakeCaret, FieldSet, FilePicker, FitLayout, FlexLayout, FloatPanel, FlowLayout, FocusManager, ForceBlocks, Form, FormatControls, Formatter, FormItem, Fun, GridLayout, I18n, Iframe, ImageScanner, JSON, JSONP, JSONRequest, KeyboardNavigation, Label, Layout, LegacyInput, LineUtils, LineWalker, ListBox, LocalStorage, Menu, MenuBar, MenuButton, MenuItem, MessageBox, Mode, Movable, Node, NodeChange, NodePath, NodeType, Notification, NotificationManager, Observable, ObservableObject, Panel, PanelButton, Path, Preview, Progress, Promise, Quirks, Radio, Range, RangeUtils, Rect, ReflowQueue, Resizable, ResizeHandle, SaxParser, Schema, ScriptLoader, Scrollable, SelectBox, Selection, SelectionOverrides, Selector, Serializer, Serializer, Shortcuts, Sizzle, Slider, Spacer, SplitButton, StackLayout, Styles, StyleSheetLoader, TabPanel, TextBox, Throbber, Toolbar, Tools, Tooltip, TreeWalker, TridentSelection, UndoManager, Uploader, URI, VK, Widget, Window, WindowManager, Writer, XHR, Zwsp

avatar nonumber nonumber - open - 28 Mar 2016
avatar nonumber nonumber - change - 28 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 28 Mar 2016

Looks good thanks @nonumber i will test if i got back to my computer this evening :+1:

avatar nonumber
nonumber - comment - 28 Mar 2016

Maybe also good if @dgt41 takes a look at this...

avatar zero-24 zero-24 - test_item - 28 Mar 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 28 Mar 2016

I have tested this item :white_check_mark: successfully on b541e7c

Works good here.

PS: The seccond button get added to the toolbar but both buttons (with the same name) have the same function but it should not as it is just the description text that are the same :)

After the patch all works good also with the same description text.

Thanks @nonumber


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9636.

avatar wilsonge wilsonge - change - 28 Mar 2016
Milestone Added:
avatar wilsonge wilsonge - change - 28 Mar 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-03-28 20:01:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Mar 2016
avatar wilsonge wilsonge - merge - 28 Mar 2016
avatar wilsonge wilsonge - reference | 4e0462d - 28 Mar 16
avatar wilsonge wilsonge - merge - 28 Mar 2016
avatar wilsonge wilsonge - close - 28 Mar 2016
avatar wilsonge
wilsonge - comment - 28 Mar 2016

Merged on review

Add a Comment

Login with GitHub to post a comment