[#9599] - Correct check to determine if captcha was enabled
- Fixed in Code Base
- 25 Mar 2016
- Medium
- Build: staging
- # 9599
- Diff
- matrikular:patch-8
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
As reported by @yvesh the (my) implementation of the check to determine if a captcha plugin was enabled ignores the component specific settings (like com_users would do). With this PR the global configuration params act as the fallback as it should be.
Testing Instructions
- Create a contact item
- Create a menu item to that contact
- Enable the captcha plugin (make sure you have a valid key pair)
- Set the global configuration parameter (site tab) of "Default Captcha" to e.g. "- None Selected -"
- Set the "Allow Captcha on Contact" in the com_contact options form tab to "Captcha - ReCaptcha"
- Visit the contact page - you should notice that the captcha field / check is missing
- Apply the patch - the captcha field shows based on the global / components settings
Big thanks to @yvesh and @degobbis - next [favorite drink here] is on me.
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Plugins |
[ @yvesh writing @test doesnt do anything ;) You have to use the Test This button on the issue tracker (not github) - i have manually done it for you ]
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
I have tested this item 
successfully on c6a7f8b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
testet, works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
I have tested this item successfully on c6a7f8b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
I have tested this item successfully on 9c70794
looks like better :-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
I have tested this item successfully on 9c70794
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
| Status | Pending | ⇒ | Ready to Commit |
RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9599.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-25 22:09:08 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
@Test working fine. Thanks!