[#9540] - Update mod_breadcrumbs.xml
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9540
- Diff
- Twincarb:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9521 .
Summary of Changes
set default install value for mod_breadcrumbs caching value to off '0' also caching time to '0' so that it has to be a definite wish to enable it.
Testing Instructions
This PR will only have an effect from a clean install on selecting a new breadcrumb menu, going to the advanced settings cache should by default be disabled and caching time 0
I need to find the sample install data and check to see if it's enabled at all please hold off testing at the moment, but I welcome comments.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 9521 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Cache Modules |
Yes in all db drivers
And it should be changed in sample data database SQL too.
Daft question, how do I update my PR?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-23 13:11:52 |
| Closed_By | ⇒ | Twincarb |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-03-23 13:11:52 | ⇒ | |
| Closed_By | Twincarb | ⇒ |
| Status | New | ⇒ | Pending |
Just update your branch and the pull request will be updated automatically
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.
you have to update the files in your "patch-2" branch
https://github.com/Twincarb/joomla-cms/tree/patch-2
any changes you made in that branch will automatically will be in this PR.
I think that's all the files that needed adjusting, I can't find the location for adjusting the tool tip for caching on the advanced tab, it anyone can point me in the right direction...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.
that string (COM_MODULES_FIELD_CACHING_DESC) is global for all modules.
the location is https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_modules.ini#L37
@andrepereiradasilva Thanks for the pointer, I was thinking it was possibly going to be a global string, it's beyond my ability to set it up to something separate for the one module.
The db drivers, which files am I looking for, all of the sql folder files are updated.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.
I have tested this item 
successfully on 760bfcb
Tested by code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.
I have tested this item successfully on 760bfcb
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 22:52:11 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
Merged - thanks!
rdeutz
- | Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Yep, it also needs chnages in the joomla.sql for each db: