Add breadcrumbs and turn on caching
Visit 1 article
Visit another article it will show the first page title
Show the 2nd article title
Shows the 1st article title
There already have been some issues about this and a PR #3269
Which was closed because of a file rename 0_o
Other people with the same issue:
http://forum.joomla.org/viewtopic.php?f=708&t=893447
https://developer.joomla.org/joomlacode-archive/issue-33093.html
#5188
@brianteeman File caching, when disabling the breadcrumb module cache it works fine.
But it should not have this option if it won't work properly with caching.
You are probably correct that the option should not be there as it can
never work.
On 22 March 2016 at 14:42, Chris de Kok notifications@github.com wrote:
@brianteeman https://github.com/brianteeman File caching, when
disabling the breadcrumb module cache it works fine.
But it should not have this option if it won't work properly with caching.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9521 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This is an old issue that it seems never got resolved.
I had to disable caching in all breadcrumb modules in all sites a long time ago to avoid this issue.
I agree with @cdekok and @brianteeman this should be resolved in future releases.
Category | ⇒ | Cache Modules |
Status | New | ⇒ | Confirmed |
Labels |
Added:
?
|
Would it be sufficient to remove the option from Joomla breadcrumbs module for caching, as the same issue can be created by using breadcrumbs from other authors.
There is nothing we can do about external modules
am I looking at this to simply in, mod_breadcrumbs.xml
change line 80 to hidden
change line 81 to 0
change line 91 to hidden
change line 92 to 0
and then a check in the db to check that the settings are as above? which would cover both new installs and current installs.
I am happy giving the PR a go.
79 name="cache"
80 type="list"
81 default="1"
82 label="COM_MODULES_FIELD_CACHING_LABEL"
83 description="COM_MODULES_FIELD_CACHING_DESC">
84
85 value="1">JGLOBAL_USE_GLOBAL
86
87 value="0">COM_MODULES_FIELD_VALUE_NOCACHING
88
89
90 name="cache_time"
91 type="text"
92 default="900"
93 label="COM_MODULES_FIELD_CACHE_TIME_LABEL"
94 description="COM_MODULES_FIELD_CACHE_TIME_DESC" />
Sure, please make a PR
I have doubts it should be hidden - what will happen in sites with caching already enabled in breadcrumbs - can they change it if it's hidden?
Also if i have a site with no categories i would like to cache the breadcrumb.
But agree with putting a default value of 0 (no caching).
I think that realistically all we can do is to change the default value for
NEW installs to no caching. NOTE you might need to check the sample data
sql as well to see if it is saved there as well.
My logic was that by default the use of caching breadcrumbs has no value, but if as you suggest there are occasions when caching breadcrumbs can work then the easy way is to set the default to no caching and a tooltip to say "Caching can have undesirable results with dynamic content sites. Recommended state is disabled." Not making any change to it's visibility.
Applying the above logic wouldn't need a db check or change. Although it may be beneficial to do a db check to see if the module is installed but not enabled and if so adjust the defaults to '0'.
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-23 09:54:38 |
Closed_By | ⇒ | brianteeman |
Closed as we have a PR #9540
Am I allowed to open this topic again? I just realised that breadcrumbs with cache disabled now have issues if Global settings -> System Cache -> On - Conservative caching is set. This is somehow still caching the Breadcrumbs which results in faulty behaviour. I can't remember this happening when i built the website a few months ago. So probably slipped in a recent joomla update? Running Joomla! 3.9.22 @ PHP 7.3.23
Can we confirm this is the case? Hope i'm not the only one ;)
@BruTaLysT it makes sense or add a new bug report, I totally forgot about this looking at the PR it just sets the default caching to 0, but it would still be an issue if you enable the caching, the option should be removed totally from the xml if it's not possible to cache.
imo it's a new issue so long as the following are set in the module:
Caching. No Caching.
Cache Time. 0.
The original issue was caused by "caching being enabled by default" which was solved by setting the defaults to caching disabled for the module, which works for new sites but doesn't prevent anyone from changing it.
The reason it wasn't removed is if would prevent a site that cached the module to change the setting in the future, and depending on the site format the breadcrumbs can be cached safely.
@Twincarb, Indeed that's the case. No Caching / Cache Time 0 are set on the Breadcrumbs module. The Global Configuration cache setting somehow overrides the module's cache setting and still manages to cache the Breadcrumbs. Could this also be the case for other modules specifically set to NOT cache? I just tested this with a News website I manage. Certain modules should not cache or they display the wrong information. While Global config is set to 'On - Conservative caching' these modules indeed do NOT cache. They seem to work correctly. So this is possibly only a breadcrumbs thing?
Which caching option are you selecting?
Do you have the caching in the breadcrumbs module set to OFF
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9521.