? ? ? Success

User tests: Successful: Unsuccessful:

avatar matrikular
matrikular
20 Mar 2016

Summary of Changes

This PR allows to set the mailto link for each contact individually.

With the additional change to move the cloak handling into the layout, it there can easily be overridden. Also, it is now possible to access the unmodified email address.

Note: language files were changed and help screens might need to be updated.

Test Instructions

  1. Back-end: Create a contact. Give it a title and make sure to fill out the email address field. The contact doesn't have to be assigned to a user or a category. For easy access, create a menu item to that contact in a menu of your choice.
  2. Front-end: Verify that the email address including the mailto link is visible in the front-end. If not, please check the settings for com_contact.
  3. Back-end: Go to the component settings and set "Add Mailto: Link" to "No"
  4. Front-end: Refresh the page. Without the patch you will see that the email address will always have a mailto link attached to it.
  5. Front-end / Back-end: Apply the patch and check again. The mailto link can now be switched on or off via component, contact or menu item settings.
avatar matrikular matrikular - open - 20 Mar 2016
avatar matrikular matrikular - change - 20 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2016
Labels Added: ? ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2016

I was unable to fit your Instructions:

  1. How to assign a Contact not to a Contact-Category? If i delete all Categories got "Invalid field: Category"
  2. Can't find "Add Mailto: Link" in com_contact. Or you mean with "Go to the component settings ..." Plugin "Content - Email Cloaking", where a "Mode: Non-linkable Text" exist.

Please can you explain so i can Test or do i understand some completely wrong?

avatar matrikular
matrikular - comment - 20 Mar 2016

@franz-wohlkoenig thank you for your feedback.

What I ment was that you don't have to assign the contact to a category other that "Uncategories". You did not have to delete any categories.

The "Add Mailto: Link" parameter in the com_contact options dialoge is only available after you apply the patch There is no connection to the email cloak plugin anymore.

com_contact_options_contact_tab

Of course you can also change the parameter in a contact item or in the menu item options it belongs to.

avatar nikitadhiman nikitadhiman - test_item - 20 Mar 2016 - Tested successfully
avatar nikitadhiman
nikitadhiman - comment - 20 Mar 2016

I have tested this item :white_check_mark: successfully on 90d51bd

The patch works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Mar 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2016

I have tested this item :white_check_mark: successfully on 90d51bd

Tested on Contact General Options, Menu Options and Contact Options to show/hide "Add Mailto: Link".


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar brianteeman brianteeman - change - 22 Mar 2016
Category Components
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels
avatar zero-24
zero-24 - comment - 27 Mar 2016

@brianteeman can we get a RTC label here?

avatar brianteeman
brianteeman - comment - 27 Mar 2016

Someone else will have to do it. I wont personally set a new feature to RTC
if I dont understand it

On 27 March 2016 at 11:20, zero-24 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman can we get a RTC label here?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9490 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 27 Mar 2016

no Problem. @wilsonge can you set it RTC?

avatar Luchen6 Luchen6 - test_item - 15 Apr 2016 - Tested unsuccessfully
avatar Luchen6
Luchen6 - comment - 15 Apr 2016

I have tested this item :red_circle: unsuccessfully on 90d51bd

Tested the option for contact and component,
could not find the option in the menu option.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar brianteeman brianteeman - change - 27 Apr 2016
Category Components Components Language & Strings
avatar brianteeman brianteeman - change - 27 Apr 2016
Labels
avatar toxic2302 toxic2302 - test_item - 2 Aug 2016 - Tested successfully
avatar toxic2302
toxic2302 - comment - 2 Aug 2016

I have tested this item successfully on 90d51bd

I follow your test instructions and without the patch I have a permanent mailto link. After applying the patch I can switch the mailto link off or on.
It works for me correctly.

@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar Curtista Curtista - test_item - 2 Aug 2016 - Tested successfully
avatar Curtista
Curtista - comment - 2 Aug 2016

I have tested this item successfully on 90d51bd

I followed the test steps and before the patch there was a permanent mailto link. After applying the patch the link was gone.
Worked for me.

@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar roland-d
roland-d - comment - 2 Aug 2016

@matrikular Can you please update your PR so the merge conflicts are resolved? Thank you.

avatar BhaveshTailored BhaveshTailored - test_item - 27 Aug 2016 - Tested successfully
avatar BhaveshTailored
BhaveshTailored - comment - 27 Aug 2016

I have tested this item successfully on 90d51bd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar bhavikTailored bhavikTailored - test_item - 27 Aug 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 27 Aug 2016

I have tested this item successfully on 90d51bd

I have tested successfully. I think you should do RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9490.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Aug 2016

without conflicts solved there is no RTC

avatar matrikular
matrikular - comment - 28 Aug 2016

Could someone please confirm that the conflicts have been resolved by the last commit?

avatar brianteeman
brianteeman - comment - 28 Aug 2016

All good - conflicts resolved
This branch has no conflicts with the base branch

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Apr 2017

"This branch has conflicts that must be resolved"

avatar bertmert
bertmert - comment - 1 Apr 2017

Is there a possibility to communicate this change to admins, e.g. via post-installation message.
If one is using a template override for components/com_contact/views/contact/tmpl/default_address.php with "old"

<?php echo $this->contact->email_to; ?>

instead of "new"

<?php echo JHtml::_('email.cloak', $this->contact->email_to, (bool) $this->params->get('add_mailto_link', true)); ?>

the result will be a not cloaked email address in FE because cloaking has been removed from view.html.php with this PR.

avatar brianteeman
brianteeman - comment - 1 Apr 2017

It is not correct to move the cloaking code

avatar matrikular
matrikular - comment - 1 Apr 2017

@bertmert seems to be a good idea. Either that and / or introducing something similar to $item->email_to_raw, $this>contact->email_to_raw. What do you think?

As you may know, preventing access to the raw email address by cloaking it in the view was a bad choice in the first place.

As to the conflicts, I'll look into that.

avatar matrikular
matrikular - comment - 11 May 2017

Please see #15973

avatar matrikular matrikular - change - 11 May 2017
The description was changed
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-11 17:55:54
Closed_By matrikular
avatar matrikular matrikular - close - 11 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2017
Category Components Language & Strings Administration com_contact Language & Strings Front End Components

Add a Comment

Login with GitHub to post a comment