User tests: Successful: Unsuccessful:
This PR allows to set the mailto link for each contact individually.
With the additional change to move the cloak handling into the layout, it there can easily be overridden. Also, it is now possible to access the unmodified email address.
Note: language files were changed and help screens might need to be updated.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Labels |
Added:
?
?
|
@franz-wohlkoenig thank you for your feedback.
What I ment was that you don't have to assign the contact to a category other that "Uncategories". You did not have to delete any categories.
The "Add Mailto: Link" parameter in the com_contact options dialoge is only available after you apply the patch There is no connection to the email cloak plugin anymore.
Of course you can also change the parameter in a contact item or in the menu item options it belongs to.
I have tested this item successfully on 90d51bd
The patch works!
I have tested this item successfully on 90d51bd
Tested on Contact General Options, Menu Options and Contact Options to show/hide "Add Mailto: Link".
Category | ⇒ | Components |
Labels |
Added:
?
|
Labels |
@brianteeman can we get a RTC
label here?
Someone else will have to do it. I wont personally set a new feature to RTC
if I dont understand it
On 27 March 2016 at 11:20, zero-24 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman can we get a RTC label here?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9490 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item unsuccessfully on 90d51bd
Tested the option for contact and component,
could not find the option in the menu option.
Category | Components | ⇒ | Components Language & Strings |
Labels |
I have tested this item
I follow your test instructions and without the patch I have a permanent mailto link. After applying the patch I can switch the mailto link off or on.
It works for me correctly.
I have tested this item
I followed the test steps and before the patch there was a permanent mailto link. After applying the patch the link was gone.
Worked for me.
@matrikular Can you please update your PR so the merge conflicts are resolved? Thank you.
I have tested this item
I have tested this item
I have tested successfully. I think you should do RTC.
without conflicts solved there is no RTC
Could someone please confirm that the conflicts have been resolved by the last commit?
All good - conflicts resolved
This branch has no conflicts with the base branch
"This branch has conflicts that must be resolved"
Is there a possibility to communicate this change to admins, e.g. via post-installation message.
If one is using a template override for components/com_contact/views/contact/tmpl/default_address.php
with "old"
<?php echo $this->contact->email_to; ?>
instead of "new"
<?php echo JHtml::_('email.cloak', $this->contact->email_to, (bool) $this->params->get('add_mailto_link', true)); ?>
the result will be a not cloaked email address in FE because cloaking has been removed from view.html.php
with this PR.
It is not correct to move the cloaking code
@bertmert seems to be a good idea. Either that and / or introducing something similar to $item->email_to_raw, $this>contact->email_to_raw. What do you think?
As you may know, preventing access to the raw email address by cloaking it in the view was a bad choice in the first place.
As to the conflicts, I'll look into that.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-11 17:55:54 |
Closed_By | ⇒ | matrikular |
Category | Components Language & Strings | ⇒ | Administration com_contact Language & Strings Front End Components |
I was unable to fit your Instructions:
Please can you explain so i can Test or do i understand some completely wrong?