? Success

User tests: Successful: Unsuccessful:

avatar matrikular
matrikular
19 Mar 2016

Summary of Changes

With the proposed changes the boolean flag "$mailto" is passed to the JHtmlEmail::cloak method so the email shown in the contact view is influenced by the email cloak plugins (settings) without triggering it.

Why do it this way?

One could argue that this flag could / should be in com_contact itself and I agree - on the long run, surely the better option. I'm working on a PR for that, too. Regarding the current implementation: I didn't want to call the plugin directly or via JHtmlContent::prepare, since we only need the plugins mode parameter value here.

Test Instructions

  1. Back-end: Create a contact. Give it a title and make sure to fill out the email address field. The contact doesn't have to be assigned to a user or a category. For easy access, create a menu item to that user.
  2. Front-end: Verify that the email address including the mailto link is visible in the front-end. If not, please check the settings for com_contact.
  3. Back-end: Go to the plugin section and edit the "Content - Email Cloaking" plugin. The only parameter there is the "mode" switch. Set / Change it to "Non-linkable Text".
  4. Front-end: Refresh the page. Without the patch you will see that the email address will always have a mailto link attached to it.
  5. Front-end / Back-end: Apply the patch and check again. The mailto link can now be switched on or off via the email cloak plugin.
avatar matrikular matrikular - open - 19 Mar 2016
avatar matrikular matrikular - change - 19 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2016
Labels Added: ?
avatar matrikular
matrikular - comment - 20 Mar 2016

Closed - Superseded by: #9490

avatar matrikular matrikular - change - 20 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-20 00:56:04
Closed_By matrikular
avatar matrikular matrikular - close - 20 Mar 2016

Add a Comment

Login with GitHub to post a comment