[#9458] - user profile plugin - Terms of Service prevent NOTICE
- Fixed in Code Base
- 18 Mar 2016
- Medium
- Build: staging
- # 9458
- Diff
- alikon:patch-60
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue follow of #9405 .
Summary of Changes
a better check
Testing Instructions
please carefully test the user profile plugin about tos mainily
frontend register , edit etc
backend new , edit , etc
Comment
any feedback is warmly wellcomed
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Plugins |
| Rel_Number | 0 | ⇒ | 9405 |
| Relation Type | ⇒ | Pull Request for |
| Labels |
Added:
?
|
||
noooo 
2nd yellow card on same #pr i will miss next match
Hehe :) good that we are not at soccer here :)
I have tested this item 
successfully on a85ccc5
TOS works as expected in the front end and no issues found when modifying as user or admin.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9458.
This PR has received new commits.
CC: @Twincarb
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9458.
@joomdonation hoping to not miss more than 1 match ;)
@alikon It looks OK now. However, I think you have too many ( and ) in the code (which is not needed). I think you can change the code to to make it easier to read:
$task = JFactory::getApplication()->input->getCmd('task');
$option = JFactory::getApplication()->input->getCmd('option');
$tosarticle = $this->params->get('register_tos_article');
$tosenabled = $this->params->get('register-require_tos', 0);
if ($option == 'com_users' && $task == 'register' && $tosarticle && $tosenabled == 2 && !$data['profile']['tos'])
{
throw new InvalidArgumentException(JText::_('PLG_USER_PROFILE_FIELD_TOS_DESC_SITE'));
}
@alikon is this ready for testing? or do you want to add the fixes by @joomdonation
Is ready for test IMHO , is readable for me but this my personal feeling
My personal feeling, too. If maintainer decides that the changes is not needed, then count me as one successful test.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-18 14:33:01 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@wilsonge @brianteeman can you add the release blocker label? If i get some time tomorrow or on saturday i can try to test this.
Thanks @alikon for the patch