I have tested this item successfully on fabda47

Dont know if programmatically it is good or bad but it works for me

i suspect shuold be handled better on js side .... but i'm not that man ;)

This PR has received new commits.

CC: @brianteeman

I have tested this item successfully on 4d88da8

Works good here! Thanks

I have tested this item successfully on 4d88da8

RTC

@wilsonge
This should go in as it solves a regression

@joomdonation can you check carefully #9439

@alikon The issue is still there. If you add this command

error_reporting(E_ALL);

before the command you added. And add this command after the command

exit();

Then edit a user from backend, save it, there will be a notice displayed like this:

Undefined index: tos in E:\www\beta3\plugins\user\profile\profile.php on line 369

@joomdonation thx for the review i'll add

if (!empty($data["profile"]["tos"]))
{
// code
}


Yes @alikon. That will prevent the notice.

Can you make a patch?

I'll do this evening...

Actually, beside the notice, there is still bug in the current code. If tos is required, you won't be able to update your profile in frontend.

We only need to validate tos when user register for an account, so I think we can change the current code to use this new code:

$task = JFactory::getApplication()->input->getCmd('task');
$tosarticle = $this->params->get('register_tos_article');
$tosenabled = $this->params->get('register-require_tos', 0);

if ($task == 'register' && $tosarticle && $tosenabled == 2 && empty($data['profile']['tos']))
{
    throw new InvalidArgumentException(JText::_('PLG_USER_PROFILE_FIELD_TOS_DESC_SITE'));
}

@infograf768 @joomdonation
please may i have a proof look #9458

If tos is required, you won't be able to update your profile in frontend.

i'm unable to replicate
this is what i get for profile data when visiting profile page index.php/profile?task=profile.save
`
'profile' =>
array (size=11)
'address1' => string '' (length=0)
'address2' => string '' (length=0)
'city' => string '' (length=0)
'region' => string '' (length=0)
'country' => string '' (length=0)
'postal_code' => string '' (length=0)
'phone' => string '' (length=0)
'website' => boolean false
'favoritebook' => string '' (length=0)
'aboutme' => string '' (length=0)
'dob' => string '' (length=0)

`
no 'tos' !!!