User tests: Successful: Unsuccessful:
Pull Request for Issue #9401 and #9392.
This forward port the changes we made in 2.5.x to 3.x if we have no download URL: 73f5601
relevant are only that changes to administrator/components/com_joomlaupdate/views/default/tmpl/default.php
and administrator/language/en-GB/en-GB.com_joomlaupdate.ini
the others are backeportes from 3.x to 2.5.x that day.
You should get a message that there are no download URL availiable.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
available. not availiable I guess.
@infograf768 is correct - hard to see on my phone :)
I still say these patches are only bandages over the real issue and that's inside the JUpdater
library. That comment on the other issue about the update still showing on the control panel supports that theory. JUpdater
should NOT be presenting an update if it does not have a fully valid record, and what's causing these undefined index errors is the fact that the update definition is not complete/valid for 3.5. To be presented an update when using a collection update stream, you should need both a valid entry in the base collection XML file (our list.xml) AND the extension XML file (our extension.xml). Right now, Joomla treats only the entry in the collection XML file as enough to say an update is available.
hmm there is one condition where this can happen. And this is the We don't support your PHP Version
. There you have a valid entry for the list.xml and for the extension.xml but as the update don't support your PHP Version there is no download URL available. But we want to show the message Hey please update your PHP to get more updates.
;)
The extension XML file would still have a valid update definition for that version though. Right now, there isn't a valid update definition for 3.5 across the board. https://update.joomla.org/core/test/list_test.xml has a potential update for 3.5 users listed, but https://update.joomla.org/core/teststs/extension_sts.xml does not and that's why JUpdater is getting confused; since the latter doesn't even have a supporting update for 3.5, it should negate the former file saying "hey, there's an update available".
Also, the PHP minimum version check is already handled in the extension update adapter so it shouldn't need to be duplicated into the update component.
This works, just made some comments to the text.
Category | ⇒ | Updating |
Labels |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-26 19:16:53 |
Closed_By | ⇒ | zero-24 | |
Labels |
@brianteeman can you have a look into the language string. I guess it needs improving or are you ok with it?