? Success
Pull Request for # 9381

User tests: Successful: Unsuccessful:

avatar sapphireweb
sapphireweb
13 Mar 2016

Pull Request for Issue # .

Summary of Changes

Changing line 230 of cms.php to handle non-empty, blank messages.

Testing Instructions

The current code, if (!strlen($msg)) still allows blank messages to be added to the messageQue. Changing line 230 to, if (!strlen(trim($msg))) removes whitespace before checking the length, insuring that a message full just spaces won't be added,

avatar sapphireweb sapphireweb - open - 13 Mar 2016
avatar sapphireweb sapphireweb - change - 13 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 13 Mar 2016

How to test

  • Go to the Template Manager
  • Edit the index.php of your template
  • add this code JFactory::getApplication()->enqueueMessage(' ', 'error');
  • refresh the frontend
  • see the empty error message
  • apply this patch
  • message is gone.

:+1:

avatar zero-24 zero-24 - test_item - 13 Mar 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 13 Mar 2016

I have tested this item :white_check_mark: successfully on a12f627

Works here see my test instructions. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9403.

avatar Twincarb Twincarb - test_item - 13 Mar 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 13 Mar 2016

I have tested this item :white_check_mark: successfully on a12f627


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9403.

avatar brianteeman brianteeman - change - 13 Mar 2016
Rel_Number 0 9381
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 13 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9403.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Category Libraries
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels
avatar rdeutz rdeutz - change - 13 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-13 05:23:10
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 13 Apr 2016
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment