? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
13 Mar 2016

@mbabker can you review this is all that is required please? If it is please hit merge

avatar wilsonge wilsonge - open - 13 Mar 2016
avatar wilsonge wilsonge - change - 13 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 13 Mar 2016
Title
Stop putting manifest in root of package to stop extension manager up
Stop putting manifest in root of package to stop extension manager updates
avatar mbabker
mbabker - comment - 13 Mar 2016

Looks fine

avatar wilsonge wilsonge - change - 13 Mar 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-03-13 01:28:36
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Mar 2016
avatar wilsonge wilsonge - merge - 13 Mar 2016
avatar wilsonge wilsonge - reference | 9a3149c - 13 Mar 16
avatar wilsonge wilsonge - merge - 13 Mar 2016
avatar wilsonge wilsonge - close - 13 Mar 2016
avatar wilsonge wilsonge - head_ref_deleted - 13 Mar 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Mar 2016

@wilsonge i now get a warning related to JInstaller manifest or something like that after updating from 3.4.8 to 3.5.0 RC2, i think it's because of this PR.
Should it work like this or it's a bug?

avatar mbabker
mbabker - comment - 14 Mar 2016

How are you updating? If the Extension Manager, fully expected. If the update component, https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L540 looks like there's no reason for it to spit out errors.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Mar 2016

update component

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Mar 2016

to prove i'm not nuts ;)

image

avatar mbabker
mbabker - comment - 14 Mar 2016

Found what I'm looking for. Give me a few.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Mar 2016

also got a lot of errors in the database not sure if related

image

avatar mbabker
mbabker - comment - 14 Mar 2016

Test #9414

Add a Comment

Login with GitHub to post a comment