I have tested this item unsuccessfully on 28eeb62

get error, if enabled "Random" sort option in module. in other cases - works perfect! thanks! Error log:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 0, 5' at line 7 SQL=SELECT MAX(`tag_id`) AS tag_id, COUNT(*) AS count,MAX(t.title) AS title,MAX(`t`.`access`) AS access,MAX(`t`.`alias`) AS alias FROM `zwdj7_contentitem_tag_map` AS `m` INNER JOIN `zwdj7_tags` AS `t` ON `tag_id` = t.id INNER JOIN `zwdj7_ucm_content` AS `c` ON `m`.`core_content_id` = `c`.`core_content_id` WHERE `t`.`access` IN (1,1,5) AND `t`.`published` = 1 AND `m`.`type_alias` = `c`.`core_type_alias` AND `c`.`core_state` = 1 AND (`c`.`core_publish_up` = '0000-00-00 00:00:00' OR `c`.`core_publish_up` <= '2016-03-11 23:29:56') AND (`c`.`core_publish_down` = '0000-00-00 00:00:00' OR `c`.`core_publish_down` >= '2016-03-11 23:29:56') GROUP BY `tag_id`,`title`,`access`,`alias` ORDER BY LIMIT 0, 5

something went wrong on your side applying the pr i guess ?
when order = rand() alias Random is selected
then this code
https://github.com/alikon/joomla-cms/blob/patch-59/modules/mod_tags_popular/helper.php#L88
should render something like this
ORDER BY RAND() LIMIT 0, 5
and not like
ORDER BY <something is missing> LIMIT 0, 5

wich version of joomla are you using?

I use now Joomla! 3.4.8

$query->order('rand()');

works perfect!

yes under 3.4.8 cause of this since 3.5
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/query/mysqli.php#L134

can you test under current staging?

i.e. on 3.5?

i think was merged on 16 Jul 2015 on 3.5 branch
d6f35c3#diff-515fdfdc216c99a6f7795cd28c915887

I try it for 3.5?

yes https://github.com/joomla/joomla-cms/releases/tag/3.5.0-rc 2 days ago

on 3.5 works perfect.

I have tested this item successfully on 28eeb62

Works fine on Joomla! 3.5. Thanks!

I have tested this item successfully on 28eeb62

Works good here. Please see for a CS improvment here: alikon#18

This PR has received new commits.

CC: @vitaly80, @zero-24

As the last changes were just code style I am setting this RTC as we have two good tests