? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
11 Mar 2016

This is a Pull Request for the initial start that @brianteeman made here #9347

Same testing instructions apply

This PR includes RTL support and solves the issue with 3rd level submenus being cropped

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar C-Lodder C-Lodder - open - 11 Mar 2016
avatar C-Lodder C-Lodder - change - 11 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2016
Labels Added: ?
avatar C-Lodder C-Lodder - change - 11 Mar 2016
The description was changed
avatar brianteeman
brianteeman - comment - 11 Mar 2016

I seem to have an issue with the position of the submenu screen shot 2016-03-11 at 11 32 45


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar C-Lodder
C-Lodder - comment - 11 Mar 2016

Hmm, ok, I'll look into this over the weekend

avatar brianteeman brianteeman - change - 11 Mar 2016
Category Templates (admin)
avatar infograf768
infograf768 - comment - 12 Mar 2016

Another small glitch in RTL (double box):

screen shot 2016-03-12 at 08 47 17

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@brianteeman - I've fixed the left offset issue you mentioned.
@infograf768 - Fixed the RTL issue

avatar ot2sen
ot2sen - comment - 14 Mar 2016

Applied patch to latest stating. The scroll effect doesn´t appear.
j35_scroll_menu_after

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@ot2sen - This was only supposed to be for the "Components" dropdown.

@brianteeman - Does this need to be applied to all dropdowns?

avatar ot2sen
ot2sen - comment - 14 Mar 2016

Perhaps it only is for the Components menu as the title says? Tested the menus menu, which would have same issue often :)

avatar infograf768
infograf768 - comment - 14 Mar 2016

We also need it indeed for other dropdowns. The menus one is very important.

avatar brianteeman
brianteeman - comment - 14 Mar 2016

@C-Lodder yes it will need to be for all menus (well actually just the menu and components but might as well make it for all)

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

Okies, fixing it up now

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

Applied to all dropdowns

avatar ot2sen ot2sen - test_item - 14 Mar 2016 - Tested successfully
avatar ot2sen
ot2sen - comment - 14 Mar 2016

I have tested this item :white_check_mark: successfully on 85278b9

Tested successful with latest patch. Menu now scrollable


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar ot2sen
ot2sen - comment - 14 Mar 2016

Thanks @C-Lodder works now :)
j35_scroll_menu_new_after_ok

avatar C-Lodder C-Lodder - change - 14 Mar 2016
Title
Components menu dropdown now scrollable
Isis: Navbar dropdowns are now scrollable
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Mar 2016

This PR has received new commits.

CC: @ot2sen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@ot2sen - There was a slight issue which is now fixed. If you to go "Extensions" >> "Manage", a scrollbar will be added to the dropdown. This was caused by the original <ul> element still being shown. This has been fixed with: f18c456

avatar ot2sen ot2sen - test_item - 14 Mar 2016 - Tested successfully
avatar ot2sen
ot2sen - comment - 14 Mar 2016

I have tested this item :white_check_mark: successfully on f18c456

Retested with fix for extensions manage. That extra scrollbar is now gone and the intended scrollbars is a menus.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar MATsxm MATsxm - test_item - 14 Mar 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 14 Mar 2016

I have tested this item :white_check_mark: successfully on f18c456

This is just fabulous and a real improvement!

Thanks all and of course @C-Lodder


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar brianteeman
brianteeman - comment - 14 Mar 2016

Working great - do you think there should be some sort of visual indicator at the end of the column to indicate there is more if you scroll?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@brianteeman - I like to think that people have at least some common sense and know what a scroll bar is for :)

I can add otherwise though

avatar brianteeman
brianteeman - comment - 14 Mar 2016

You only see the scollbar when you over over the menu itself. If you only
click on Menu (or) Component then the scrollbar does not appear so you dont
know the list is truncated

On 14 March 2016 at 16:14, Lodder notifications@github.com wrote:

@brianteeman https://github.com/brianteeman - I like to think they
people have at least some common sense and know what a scroll bar is
for :)

I can add otherwise though


Reply to this email directly or view it on GitHub
#9375 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 14 Mar 2016

In this screencapture the scrollbar ONLY appears when i try to scroll. Moving up and down or even oving to the end of the menu doesnt indicate there is anything to scroll to

dropdown-menu-bug

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@brianteeman - Oh, I think that's a Safari feature

Could you try adding the following to the template.css file:

.navbar .nav > li ul::-webkit-scrollbar {
    -webkit-appearance: none;
    width: 7px;
}
.navbar .nav > li ul::-webkit-scrollbar-thumb {
    border-radius: 4px;
    background-color: rgba(0,0,0,.5);
    -webkit-box-shadow: 0 0 1px rgba(255,255,255,.5);
}

Note: this will also style the scroll bar for Chrome and Opera, but will hopefully ensure it's always visible

avatar brianteeman
brianteeman - comment - 14 Mar 2016

Thats perfect- a scrollbar is permanently displayed if there is a scroll available

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Mar 2016

This PR has received new commits.

CC: @MATsxm, @ot2sen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar C-Lodder
C-Lodder - comment - 14 Mar 2016

@brianteeman - Applied

avatar brianteeman brianteeman - test_item - 14 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2016

I have tested this item :white_check_mark: successfully on 284ebd1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
avatar Gerlof Gerlof - test_item - 16 Mar 2016 - Tested successfully
avatar Gerlof
Gerlof - comment - 16 Mar 2016

I have tested this item :white_check_mark: successfully on 284ebd1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar brianteeman brianteeman - change - 16 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 16 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2016
Labels Added: ?
avatar Djshubh Djshubh - test_item - 19 Mar 2016 - Tested successfully
avatar Djshubh
Djshubh - comment - 19 Mar 2016

I have tested this item :white_check_mark: successfully on 284ebd1

the scrollbar works for small screens too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar wilsonge wilsonge - change - 6 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-06 08:58:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Apr 2016
avatar wilsonge wilsonge - merge - 6 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 6 Apr 2016
avatar wilsonge wilsonge - reference | 1af1fe5 - 6 Apr 16
avatar wilsonge wilsonge - merge - 6 Apr 2016
avatar wilsonge wilsonge - close - 6 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2016
Labels Removed: ?
avatar C-Lodder C-Lodder - head_ref_deleted - 6 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment