? Success
Pull Request for # 8928

User tests: Successful: Unsuccessful:

avatar GABBAR1947
GABBAR1947
7 Mar 2016

Pull Request for Issue # 8928

Summary of Changes
If the min value is set to negative then value , by default value was set to the min-value. Solved by replacing a few lines of code.

Testing Instructions
As stated in the issue #8928

avatar GABBAR1947 GABBAR1947 - open - 7 Mar 2016
avatar GABBAR1947 GABBAR1947 - change - 7 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 9 Mar 2016
Rel_Number 0 8928
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 10 Mar 2016
Category Fields
avatar RonakParmar RonakParmar - test_item - 16 Mar 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 16 Mar 2016

I have tested this item :white_check_mark: successfully on 25e98ea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar nibra
nibra - comment - 18 Mar 2016

As the tests show, this approach breaks compatibility. If neither value nor min are given, the resulting HTML must contain value="".

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar GABBAR1947
GABBAR1947 - comment - 18 Mar 2016

@nibra can you have a look. I modified the code accordingly.

avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Mar 2016

This PR has received new commits.

CC: @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar nibra
nibra - comment - 19 Mar 2016

Tests pass, so it's fine. @RonakParmar, could you test once again?

avatar RonakParmar RonakParmar - test_item - 21 Mar 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 21 Mar 2016

I have tested this item :white_check_mark: successfully on 4620164


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar andrepereiradasilva andrepereiradasilva - test_item - 29 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Mar 2016

I have tested this item :white_check_mark: successfully on 4620164


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 30 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9336.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 6f67925 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:36:50
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment