[#9295] - Add class deafult to homepage menu item
- Fixed in Code Base
- 4 May 2016
- Medium
- Build: staging
- # 9295
- Diff
- artur-stepien:patch-8
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 2 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
That should be right from the start. Many themes are displaying default menu item differently or disables at all.
Summary of Changes
This adds a default class for a homepage/default menu item in current language.
Testing Instructions
Just check if menu item containing item marked as default/homepage has class default.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
Fatal error: Call-time pass-by-reference has been removed in /modules/mod_menu/helper.php on line 191
Fixed that. Will check that all and give and comment again.
I have tested this item 
successfully on 25f4775
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
Yup, now works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
I have tested this item successfully on 25f4775
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
| Status | Pending | ⇒ | Ready to Commit |
| Category | ⇒ | Templates (site) |
RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
| Labels |
Added:
?
|
||
I have tested this item 
unsuccessfully on 25f4775
Undefined property: stdClass::$anchor_rel in /opt/lampp/htdocs/joomla-test/modules/mod_menu/tmpl/default_url.php on line 15
this message is shown with every menu component after applying the patch on my testing site.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
First of all if you are about to test this, clone a full branch. Not only some files. If there is something wrong with your Joomla instance (for example few patches with conflicts) it will be like this. Clone a full system then test it again please.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.
@artur-stepien could you check the merge conflicts, thanks
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-04 15:25:40 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
unsuccessfully on 5eacf43
Fatal error: Call-time pass-by-reference has been removed in /modules/mod_menu/helper.php on line 191
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9295.