? Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
3 Mar 2016

Pull Request for Issue #9292 .

Summary of Changes

This PR corrects a silly syntax error in the installation sql script joomla.sql for PostgreSQL I've made with my PR #9269 .

When removing the unique key definition at the end of the create table, I forgot to remove also the comma (shame).

Testing Instructions

Only relevant for PostgreSQL database users.

Do a new installation either with Joomla! 3.5.0 Beta 3 or current staging, but before you start, replace the file installation/sql/postgresql/joomla.sql by the one from this PR.

Result: The syntax error described in issue #9292 does not happen anymore, and the table for the redirect links is created.

If no other errors, installation should succeed, otherwise if new erros let me know here.

If all OK, please mark your test result in the issue tracker for this PR.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar richard67 richard67 - open - 3 Mar 2016
avatar richard67 richard67 - change - 3 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Added: ?
avatar richard67 richard67 - change - 3 Mar 2016
Title
Correct silly syntax error
[Bug fix] Correct issue 9292 syntax error in joomla.sql for PostrgeSQL
avatar richard67 richard67 - change - 3 Mar 2016
Title
Correct silly syntax error
[Bug fix] Correct issue 9292 syntax error in joomla.sql for PostrgeSQL
avatar richard67
richard67 - comment - 3 Mar 2016

Changed title to being more descriptive


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar richard67
richard67 - comment - 3 Mar 2016

@alikon It seems there failed some unit test for PHP 5.4, but it seems not related to this PR, or is it? Can you check, or have an idea who can?

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

not expert, but maybe "header" INTEGER should be integer (lower case)?

avatar richard67
richard67 - comment - 3 Mar 2016

@andrepereiradasilva Thanks, this fixed it.

avatar richard67 richard67 - change - 3 Mar 2016
The description was changed
avatar richard67 richard67 - change - 3 Mar 2016
Title
[Bug fix] Correct issue 9292 syntax error in joomla.sql for PostrgeSQL
[Bug fix] Correct issue 9292 syntax error in joomla.sql for PostrgeSQL
avatar richard67
richard67 - comment - 3 Mar 2016

@Dygear Could you mark your test result as success then at the issue tracker? Just go to https://issues.joomla.org/tracker/joomla-cms/9294, click the "Test this" button at the to left area and then select the test result. Thanks.

avatar Dygear Dygear - test_item - 3 Mar 2016 - Tested successfully
avatar Dygear
Dygear - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on f57d30a

Now install under PostgreSQL 9.5.1 with PHP 7.0.3 without issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar richard67
richard67 - comment - 3 Mar 2016

Thanks for testing. One more tester with a PostgreSQL database available, please. Maybe @alikon ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar alikon
alikon - comment - 3 Mar 2016

I'll do this evening , now busy ;)
On 3 Mar 2016 2:22 pm, "Richard Fath" notifications@github.com wrote:

Thanks for testing. One more tester with a PostgreSQL database available,

please. Maybe @alikon https://github.com/alikon ?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9294
https://issues.joomla.org/tracker/joomla-cms/9294.


Reply to this email directly or view it on GitHub
#9294 (comment).

avatar richard67
richard67 - comment - 3 Mar 2016

Thanks in advance.

avatar alikon alikon - test_item - 3 Mar 2016 - Tested successfully
avatar alikon
alikon - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on f57d30a

tested under

PHP 5.5.30
PostgreSQL 9.4.5

p.s.
very happy to see attention about PostgreSQL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar richard67
richard67 - comment - 3 Mar 2016

Thanks for testing to all testers.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar brianteeman brianteeman - change - 3 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 3 Mar 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9294.

avatar wilsonge wilsonge - change - 3 Mar 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-03-03 20:12:21
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 3 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 Mar 2016
avatar wilsonge wilsonge - reference | 83cda46 - 3 Mar 16
avatar wilsonge wilsonge - merge - 3 Mar 2016
avatar wilsonge wilsonge - close - 3 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Removed: ?
avatar richard67 richard67 - head_ref_deleted - 4 Mar 2016

Add a Comment

Login with GitHub to post a comment