? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
2 Mar 2016

When editor buttons (editors-xtd plugins) are initiated via the onDisplay($name) event, the $name should contain the id of the editor field (textarea).

However, with the new J3.5 changes to TinyMCE, it always passes its own name (tinymce) instead of the editor field id.

So for instance when creating/editing an article, the editor buttons for the content field should get jform_articletext through the onDisplay($name). Instead they get tinymce.

This PR fixes that.

Testing

You can test this by - for example - adding this to the public function onDisplay($name):
joomla/j35/plugins/editors-xtd/readmore/readmore.php (line 36)

echo "\n\n<pre>==========================\n";
print_r($name);
echo "\n==========================</pre>\n\n";

Edit or create an article.

Before:

After

Apply the patch.
You should see this if the fix is successful, when

avatar nonumber nonumber - open - 2 Mar 2016
avatar nonumber nonumber - change - 2 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Added: ?
avatar nonumber nonumber - change - 2 Mar 2016
The description was changed
avatar infograf768
infograf768 - comment - 2 Mar 2016

@dgt41
Can you look at this?

avatar dgt41
dgt41 - comment - 2 Mar 2016

I agree with the changes. When I moved the code from onInit() to onDisplay() I should have checked that the correct id was passed. Also since the core plugins were working I guess nobody really tested this against a 3pd button...
Thanks @nonumber for fixing this

avatar dgt41 dgt41 - test_item - 2 Mar 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on f70390d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9283.

avatar infograf768 infograf768 - test_item - 2 Mar 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on f70390d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9283.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Title
Fixes issue with TinyMCE not passing correct field name to editor but…
regression: Fixes issue with TinyMCE not passing correct field name to editor but…
avatar infograf768 infograf768 - change - 2 Mar 2016
Title
Fixes issue with TinyMCE not passing correct field name to editor but…
regression: Fixes issue with TinyMCE not passing correct field name to editor but…
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 2 Mar 2016

rtc. @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9283.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Added: ?
avatar shubhamnba2009
shubhamnba2009 - comment - 2 Mar 2016

I have tested by applying the patch and getting the desired display as given :white_check_mark: successfully on 0db1e6f

avatar wilsonge wilsonge - change - 2 Mar 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-03-02 15:59:22
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 2 Mar 2016
avatar wilsonge wilsonge - reference | e5b3350 - 2 Mar 16
avatar wilsonge wilsonge - merge - 2 Mar 2016
avatar wilsonge wilsonge - close - 2 Mar 2016
avatar wilsonge wilsonge - change - 2 Mar 2016
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Removed: ?
avatar nonumber nonumber - head_ref_deleted - 2 Mar 2016

Add a Comment

Login with GitHub to post a comment