[#9282] - [SEO] rel attribute for external url menu item
- Closed
- 3 Mar 2016
- Medium
- Build: staging
- # 9282
- Diff
- Devportobello:menuItemAttrRel
- Success Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR add the ability to set "rel" attribute of a link when you setup a menu item type of external url.
SEO purpose.
Testing Instructions
Before patch
Create a menu item type of "External url", go to tab "Link type", there is no way to setup an rel attribute.
After patch
- Create a menu item type of "External url", add title, link (eg: https://www.google.fr/) then go to tab "Link type", there is a field "Link Rel Attribute" to setup (eg: Nofollow);
- Save.
- Go to frontend, look at html rendered by a module menu (eg: ul > li > a)
this should seem like this:
<a href="https://www.google.fr/" rel="nofollow">My external url</a>Try switching different rel value, for "None" there is no rel attribute:
<a href="https://www.google.fr/">My external url</a>Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
@shubhamnba2009 Please mark your test result as described in https://docs.joomla.org/Testing_Joomla!_patches.
I have tested this item 
successfully on 3d35139
After applying this patch I tested with every Link attribute(None,Alternate,Author,bookmark,etc) and they were applied succesfully on frontend.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9282.
I have tested this item successfully on 3d35139
works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9282.
| Status | Pending | ⇒ | Ready to Commit |
| Category | ⇒ | Front End |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9282.
| Labels |
Added:
?
|
||
I have tested this item successfully on 3d35139
This patch fixes the issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9282.
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-03 20:13:37 |
| Closed_By | ⇒ | wilsonge |
I should not have RTC this...
The values are enough as these are html code and should not be translated:
I.e.
<option value="">JNONE</option>
+ <option value="alternate">COM_MENUS_FIELD_VALUE_ALTERNATE</option>
+ <option value="author">COM_MENUS_FIELD_VALUE_AUTHOR</option>
+ <option value="bookmark">COM_MENUS_FIELD_VALUE_BOOKMARK</option>
+ <option value="help">COM_MENUS_FIELD_VALUE_HELP</option>
+ <option value="license">COM_MENUS_FIELD_VALUE_LICENSE</option>
+ <option value="next">COM_MENUS_FIELD_VALUE_NEXT</option>
+ <option value="nofollow">COM_MENUS_FIELD_VALUE_NOFOLLOW</option>
+ <option value="noreferrer">COM_MENUS_FIELD_VALUE_NOREFERRER</option>
+ <option value="prefetch">COM_MENUS_FIELD_VALUE_PREFETCH</option>
+ <option value="prev">COM_MENUS_FIELD_VALUE_PREV</option>
+ <option value="search">COM_MENUS_FIELD_VALUE_SEARCH</option>
+ <option value="tag">COM_MENUS_FIELD_VALUE_TAG</option>
should have been
+ <option value="">JNONE</option>
+ <option value="alternate">alternate</option>
+ <option value="author">author</option>
+ <option value="bookmark">bookmark</option>
+ <option value="help">help</option>
+ <option value="license">license</option>
+ <option value="next">next</option>
+ <option value="nofollow">nofollow</option>
+ <option value="noreferrer">noreferrer</option>
+ <option value="prefetch">prefetch</option>
+ <option value="prev">prev</option>
+ <option value="search">search</option>
+ <option value="tag">tag</option>
| Labels |
Removed:
?
|
||
You could even just use
<option value="">JNONE</option>
<option value="alternate"/>
<option value="author"/>
<option value="bookmark"/>
<option value="help"/>
<option value="license"/>
<option value="next"/>
<option value="nofollow"/>
<option value="noreferrer"/>
<option value="prefetch"/>
<option value="prev"/>
<option value="search"/>
<option value="tag"/>
Shall we change this before RC? (Language freeze now)
I think removing them would make sense. And since you already told the translators to not translate them we could still remove them I think.
Did i need to patch this here?
No this has been merged it should be a new PR
ok, got issue with my fork, i got on local and origin "Merge remote-tracking branch 'upstream/master'" ... unable to do a PR actually against staging.
I have tested this item
successfully on 3d35139
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9282.