PR-staging

Pending

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
28 Feb 2016

Cached some repeated and highly time-consuming jQuery selectors.
Using less CPU power, reduces the world carbon dioxide emissions.

avatar demis-palma demis-palma - open - 28 Feb 2016
avatar demis-palma demis-palma - change - 28 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2016
Labels Added: PR-staging
avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

wow, an eco friendly PR ;)

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

demis, how do we test this?

avatar demis-palma
demis-palma - comment - 28 Feb 2016

Thanks for asking @andrepereiradasilva, but I can't figure out a simple test for that.

avatar mbabker
mbabker - comment - 28 Feb 2016

That's related to the sticky subheader. It should still stick on long pages when scrolled.

avatar demis-palma
demis-palma - comment - 28 Feb 2016

Thanks @mbabker. Personally, I followed the code with my JavaScript debugger and I checked that the program flux behaves the same, but I can't figure out other kind of tests.

avatar andrepereiradasilva andrepereiradasilva - test_item - 28 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

I have tested this item :white_check_mark: successfully on 9ac6938

The menu bar and the buttons toolbar are still sticky when scrolling down on isis.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar brianteeman brianteeman - test_item - 28 Feb 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 28 Feb 2016

I have tested this item :red_circle: unsuccessfully on 9ac6938

Apply the patch
Clear the browser cache
Enable Joomla debug
Go to the Language manager and you will see the debug box is shrunk to a small box on the right hand side


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar brianteeman
brianteeman - comment - 28 Feb 2016

Same with the template manager

screen shot 2016-02-28 at 12 46 02


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar andrepereiradasilva andrepereiradasilva - test_item - 28 Feb 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

I have tested this item :red_circle: unsuccessfully on 9ac6938

I can reproduce @brianteeman test, so changed to Tested unsuccessfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar brianteeman brianteeman - change - 28 Feb 2016
Category JavaScript
avatar joomla-cms-bot
joomla-cms-bot - comment - 28 Feb 2016

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar demis-palma
demis-palma - comment - 28 Feb 2016

This is the reason I love the rule of the double human test.
Well, at the moment the code clean-up can't be applied to $('.body'), but only to $('.subhead') and $('nav.navbar')
I've added a second commit to this PR.

avatar brianteeman brianteeman - test_item - 29 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 Feb 2016

I have tested this item :white_check_mark: successfully on aa1cf08

Tested again in multiple browsers. Same problem as before


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Feb 2016

@brianteeman successfully or unsuccessfully?

avatar brianteeman brianteeman - alter_testresult - 29 Feb 2016 - brianteeman: Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 29 Feb 2016

Oops I hit the wrong button - i have edited it now to show a failure


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar roland-d
roland-d - comment - 1 Aug 2016

@demis-palma Can you have a look at the PR since there are unsuccessful tests?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Jan 2017

@demis-palma should this PR be tested?

avatar jeckodevelopment
jeckodevelopment - comment - 6 Jan 2017

and also conflicting files!

avatar mbabker
mbabker - comment - 21 May 2017

Closing PR as abandoned since there have been no updates in over a year.

avatar mbabker mbabker - change - 21 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-21 22:11:49
Closed_By mbabker
avatar mbabker mbabker - close - 21 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2017
Category JavaScript JavaScript Administration Templates (admin)

Add a Comment

Login with GitHub to post a comment