[#9243] - Inefficient jQuery selectors
- Closed
- 21 May 2017
- Medium
- Build: staging
- # 9243
- Diff
- demis-palma:fix-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Cached some repeated and highly time-consuming jQuery selectors.
Using less CPU power, reduces the world carbon dioxide emissions.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
demis, how do we test this?
Thanks for asking @andrepereiradasilva, but I can't figure out a simple test for that.
That's related to the sticky subheader. It should still stick on long pages when scrolled.
I have tested this item 
successfully on 9ac6938
The menu bar and the buttons toolbar are still sticky when scrolling down on isis.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
I have tested this item 
unsuccessfully on 9ac6938
Apply the patch
Clear the browser cache
Enable Joomla debug
Go to the Language manager and you will see the debug box is shrunk to a small box on the right hand side
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
Same with the template manager
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
I have tested this item unsuccessfully on 9ac6938
I can reproduce @brianteeman test, so changed to Tested unsuccessfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
| Category | ⇒ | JavaScript |
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
This is the reason I love the rule of the double human test.
Well, at the moment the code clean-up can't be applied to $('.body'), but only to $('.subhead') and $('nav.navbar')
I've added a second commit to this PR.
I have tested this item successfully on aa1cf08
Tested again in multiple browsers. Same problem as before
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
@brianteeman successfully or unsuccessfully?
Oops I hit the wrong button - i have edited it now to show a failure
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
@demis-palma Can you have a look at the PR since there are unsuccessful tests?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9243.
@demis-palma should this PR be tested?
and also conflicting files!
Closing PR as abandoned since there have been no updates in over a year.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 22:11:49 |
| Closed_By | ⇒ | mbabker |
| Category | JavaScript | ⇒ | JavaScript Administration Templates (admin) |
wow, an eco friendly PR ;)