[#9216] - Added Toggle Unpublished Modules in Menu item edit view
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- # 9216
- Diff
- cheiff:toggle_unpublished_modules_in_menu_item
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for a new feature.
Summary of Changes
Added a button to toggle unpublished modules in menu item edit view, similar to toggle unassigned modules.
Testing Instructions
From Administrator panel, select a menu (e.g. Main Menu), select a menu item (e.g. Home). In the Module Assignment tab, there is a new column "Published" and a new button that allows to toggle the modules based on their status (published/unpublished).
If there are some modules and some are unpublished, clicking the button will hide them.
Comments
I let the label colour for "Trashed" as default (gray) after editing a module in order to be easily recognizable. On reloading, trashed modules will disappear from the view, so it is a temporary colour.
I put the buttons next to each other in order to not take up more space. That is the reason for a new layout file for the fieldset. If there is a better way or I should let the buttons one on top of the other, just let me know.
One idiomatic question: I left the language strings same as for toggle unassigned menus, but, shouldn't it be "Shows or hides modules" instead of "Shows or hide modules"?
Thanks, regards
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
We have in core en-GB
93 occurences of "Show or hide etc."
One occurence of "Shows or hide etc."
COM_MENUS_ITEM_FIELD_HIDE_UNASSIGNED_DESC="Shows or hide modules unassigned to this menu item."
One occurence of "Shows or hides etc."
COM_TAGS_SHOW_ITEM_DESCRIPTION_DESC="Shows or hides the description for each tag listed."
@brianteeman ??
@infograf768 it should be Show or hide
On 26 February 2016 at 07:32, infograf768 notifications@github.com wrote:
We have in core en-GB
93 occurences of "Show or hide etc."
One occurence of "Shows or hide etc."
COM_MENUS_ITEM_FIELD_HIDE_UNASSIGNED_DESC="Shows or hide modules
unassigned to this menu item."
One occurence of "Shows or hides etc."
COM_TAGS_SHOW_ITEM_DESCRIPTION_DESC="Shows or hides the description for
each tag listed."
@brianteeman https://github.com/brianteeman ??—
Reply to this email directly or view it on GitHub
#9216 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman
Can you make a PR for the 2 wrong strings?
yes I will do that
On 26 February 2016 at 08:17, infograf768 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman
Can you make a PR for the 2 wrong strings?—
Reply to this email directly or view it on GitHub
#9216 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I'll correct mine, then.
Thanks, regards
There it is. Thank you.
Regards
I have tested this item successfully.
| Category | ⇒ | Administration |
| Labels | |||
I have tested this item 
successfully on 525cb78
Works as described in test instructions.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9216.
I have tested this item successfully on 525cb78
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9216.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9216.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thank you! 
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
new feature has to go into 3.6 and not into 3.5.x
oops - i didnt consider it a new feature but thats fine
| Labels |
Added:
?
|
||
@zero-24 your wish is my command :-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9216.
| Labels | |||
Thanks ;)
| Labels | |||
| Category | Administration | ⇒ | Administration Language & Strings |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 06:05:40 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Two screenshots showing what the PR does