[#9215] - Regression user notes in modal layout
- Closed
- 28 Feb 2016
- Medium
- Build: staging
- # 9215
- Diff
- andrepereiradasilva:user-notes-regression
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR solves a regression in users notes modal view.
Before PR
After PR
Testing Instructions
- Use latest staging
- Create some notes for a user.
- Go to users list and click in show user notes.
- You will see the problem described in image above.
- Apply this patch
- Repeat 3. and you'll see the correct notes.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 8b2a776
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
Wondering why we have the double numbering - it looks particularly odd when it can end up being displayed as in the screenshot below
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
@brianteeman yeah it doesn't make sense, but that is not a regression.
IMHO, this one can be RTC.
Later i will make a PR to remove the "#X" part of each note.
thats true and normally I would say a PR should tackle one issue at a time
but ...
On 26 February 2016 at 10:09, andrepereiradasilva notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman yeah it doesn't make sense,
but that is not a regression.
IMHO, this one can be RTC.Later i will make a PR to remove the "#X" part of each note.
—
Reply to this email directly or view it on GitHub
#9215 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
lol, ok i will do it here.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
ok done
I have tested this item successfully on 70d5cee
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
@infograf768 please test this one again.
may i rather suggest to keep the id and use the class "unstyled" for the list ?
This PR has received new commits.
CC: @brianteeman, @infograf768
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
done.
As this PR is to solve a regression please don't ask more changes 
much better as no change to language string (b/c).
I have tested this item successfully on b1f7529
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
I have tested this item successfully on b1f7529
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC?
| Labels |
Added:
?
|
||
thanks bot
@andrepereiradasilva so did the bot get some AI?
don't now, but i wrote RTC and magically it appeared.
The question is if "magically" is some AI or a very very fast mantainer :)
I don't remember anymore but IIRC you have to set status on the issue
tracker AND comment RTC for the label to get processed. But there's a lot
of stuff like that happening and it's hard to keep track anymore.
On Saturday, February 27, 2016, andrepereiradasilva <
notifications@github.com> wrote:
don't now, but i wrote RTC and magically it appeared.
The question is if "magically" is some AI or a very very fast mantainer :)
—
Reply to this email directly or view it on GitHub
#9215 (comment).
Yes @mbabker is correct. I forgot to comment when I changed the status
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-28 01:17:44 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 8b2a776
Confirm issue and solution.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9215.