? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
20 Feb 2016

Summary of Changes

This a small PR to improve the spacing in the error, warning, sucess and info messages.

Adds some space between title and message and removes extra space in the end.

Before PR (some examples)

image

image

After PR (some examples)

image

image

Testing Instructions

  1. Use latest staging.
  2. Apply patch
  3. Check some messages
avatar andrepereiradasilva andrepereiradasilva - open - 20 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 20 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 20 Feb 2016
Category Templates (admin) UI/UX
avatar brianteeman brianteeman - change - 20 Feb 2016
Easy No Yes
avatar rehrumesh
rehrumesh - comment - 21 Feb 2016

I tried to test this PR.

Steps:
Log in to the admin panel.
Go to Users section.
Delete the email value.
Press Save.

Following are the results I got.
2

I have highlighted the text in order to view blank spaces. I cannot see much of a difference. Please tell me if I have followed wrong steps @andrepereiradasilva .

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Feb 2016

The difference in just the bottom margin. In the second print the top margin is the same as the bottom margin.
In the first print the bottom margin is double the top margin.

avatar brianteeman brianteeman - test_item - 21 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Feb 2016

I have tested this item :white_check_mark: successfully on 2f97aa9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar infograf768
infograf768 - comment - 22 Feb 2016

the CLI generatecss.php has not been applied to this PR.
It lacks the change in isis rtl

diff --git a/administrator/templates/isis/css/template-rtl.css b/administrator/templates/isis/css/template-rtl.css
index 29092b9..8454415 100644
--- a/administrator/templates/isis/css/template-rtl.css
+++ b/administrator/templates/isis/css/template-rtl.css
@@ -2791,4 +2791,7 @@
 }
 .alert h4 {
+   margin: 0 0 .5em;
+}
+.alert p {
    margin: 0;
 }
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

true, didn't use the CLI generatecss.php has not been applied to this PR.
That was to be done in linux right?

avatar infograf768
infograf768 - comment - 22 Feb 2016

i do it on mac. unix system. you just have to use the .diff above if no time.

avatar joomla-cms-bot
joomla-cms-bot - comment - 22 Feb 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

ok, did it manually.

avatar rehrumesh
rehrumesh - comment - 22 Feb 2016

I have tested this item :white_check_mark: successfully on ad0ecfd

@andrepereiradasilva sorry for not noticing it initially. :)

avatar andrepereiradasilva andrepereiradasilva - change - 22 Feb 2016
Title
Error, warning, sucess and info messages spacing
Error, warning, success and info messages spacing
avatar RonakParmar RonakParmar - test_item - 23 Feb 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 23 Feb 2016

I have tested this item :white_check_mark: successfully on ad0ecfd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar wilsonge
wilsonge - comment - 23 Feb 2016

You can run the CLI generator on any system. For windows though - you just need to make sure you have PHP in your environment variables (e.g. http://stackoverflow.com/a/2736574/1195517)

avatar grhcj
grhcj - comment - 23 Feb 2016

@rehrumesh Please mark your test results here: https://issues.joomla.org/tracker/joomla-cms/9181 -> Login with GitHub account -> Button "Test this". Your current comment isn't counted as test result.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar rehrumesh rehrumesh - test_item - 23 Feb 2016 - Tested successfully
avatar rehrumesh
rehrumesh - comment - 23 Feb 2016

I have tested this item :white_check_mark: successfully on ad0ecfd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar rehrumesh
rehrumesh - comment - 23 Feb 2016

@grhcj Thanks for the info. :+1:

avatar brianteeman brianteeman - change - 23 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 Feb 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9181.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-23 20:35:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Feb 2016
avatar wilsonge wilsonge - reference | ce44dfc - 23 Feb 16
avatar wilsonge wilsonge - merge - 23 Feb 2016
avatar wilsonge wilsonge - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 23 Feb 2016

Add a Comment

Login with GitHub to post a comment