User tests: Successful: Unsuccessful:
When deleting cached items, the user performs and action,so like in many other views, should receive a success or error message.
So, this PR:
Also:
For testing error messages you need to simulate an error (like changing a cache group folder permissions in /cache/).
Title |
|
If in linux, did you try to change the owner/group of cache group folder to one that your php as no permissions do write?
Category | ⇒ | Templates (admin) UI/UX |
Easy | No | ⇒ | Yes |
Is Linux shared hosting, not really useful to do a chown because am not root.
this class method (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/cache/storage/file.php#L417) has to generate some kind of error (in other words, return false).
You can temporary add a return false;
in the beggining of the class method just to test.
BTW nice comment in that class method :)
@andrepereiradasilva I did modify the file as you said, but still see only a sucess message. But the size of the cache group is same, so nothing was deleted. Any idea what I do wrong?
@andrepereiradasilva No, sorry, seems files are deleted, and success message, with the file hacked as you mentioned => ???
Do you have cache enabled with "File" cache handler in global config?
Do you have https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/cache/storage/file.php#L417 starting like this?
protected function _deleteFolder($path)
{
return false;
// Sanity check
/* Rest of the code */
}
It should work.
No, I used Cache_Lite. But this one also uses the files, or not?
And the file.php I had modified like you wrote.
Anyway, I go sleep now. I will check again tomorrow if still necessary.
i don't have cache lite, but i think you must do a similiar change in this method https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/cache/storage/cachelite.php#L205
I have tested this item successfully on e44e0e5
I just switched to cache handler = File for the test.
ok thanks
Category | Templates (admin) UI/UX | ⇒ | Language & Strings Templates (admin) UI/UX |
I have tested this item successfully on e44e0e5
Status | New | ⇒ | Ready to Commit |
RTC. Thanks.
Labels |
Added:
?
|
Labels |
Added:
?
?
|
Milestone |
Added: |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:24:10 |
Closed_By | ⇒ | rdeutz |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Labels |
Removed:
?
|
@andrepereiradasilva I could test the success message, but I was not able to provoke an error for testing the error message. Rename page to page1 folder in cache, or changing permissions did not help. It seems the cache cleaner helps itself if permissions do not fit. Shall I mark my test result as success anyway?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9180.