?
Referenced as Pull Request for: # 9166
avatar infograf768
infograf768
19 Feb 2016

#9118 has broken correct update proposals in Control Panel.
I have a component com_localise which is set as 4.0.13-dev (modified, this is why I do not update to the available 4.0.14-dev).

It now displays also as a Joomla Update.

screen shot 2016-02-19 at 08 46 45

Clicking on "Update Now" will load the Joomla Update page where, evidently, no update is proposed.
The Extensions:Update page correcty displays the possible update for the component.

I had to clear the Update cache and then click on Find Updates to get rid of this error.
I am afraid that people updating to 3.5.0 would get the same issue. Any possible solution?

avatar infograf768 infograf768 - open - 19 Feb 2016
avatar wilsonge wilsonge - change - 19 Feb 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 19 Feb 2016

This has been the case for a LONG time

On 19 February 2016 at 10:45, infograf768 notifications@github.com wrote:

#9118 #9118 has broken correct
update proposals in Control Panel.
I have a component com_localise which is set as 4.0.13-dev (modified, this
is why I do not update to the available 4.0.14-dev).

It now displays also as a Joomla Update.

[image: screen shot 2016-02-19 at 08 46 45]
https://cloud.githubusercontent.com/assets/869724/13169460/faf5b862-d6e5-11e5-8235-634177cbb4be.png

Clicking on "Update Now" will load the Joomla Update page where,
evidently, no update is proposed.
The Extensions:Update page correcty displays the possible update for the
component.

I had to clear the Update cache and then click on Find Updates to get rid
of this error.
I am afraid that people updating to 3.5.0 would get the same issue. Any
possible solution?


Reply to this email directly or view it on GitHub
#9165.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Feb 2016

hum strange. It this really related to #9118?

avatar infograf768
infograf768 - comment - 19 Feb 2016

When I reversed #9118 I did not get the issue (that was before I cleared cache and click find updates).
I have another test site where I could not reproduce.

avatar brianteeman
brianteeman - comment - 19 Feb 2016

See #6091 and #5931and #3775

On 19 February 2016 at 10:56, infograf768 notifications@github.com wrote:

When I reversed #9118 #9118 I
did not get the issue (that was before I cleared cache and click find
updates).
I have another test site where I could not reproduce.


Reply to this email directly or view it on GitHub
#9165 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 19 Feb 2016

A bit different here, @brianteeman as the issue is that it proposes in Control Panel a Joomla update with a component version + the normal proposal for that component update which works OK.

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Feb 2016

@infograf768 i think i know what is the issue. a line bad placed inside an if.

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Feb 2016

i think this line https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/update.php#L146 must be placed outside the if (search).

Can you test?

Update: i have the changes here staging...andrepereiradasilva:patch-2

But i can't test so i will not make a PR if i can't test.

Can you tell me how to reproduce the problem?

avatar infograf768
infograf768 - comment - 19 Feb 2016

Hmm, the problem is that, by clearing cache, the problem disapeared...
I have to find a way to reproduce.

avatar brianteeman
brianteeman - comment - 19 Feb 2016

@infograf768 sorry I should have drunk the coffee before replying - i see what you mean now in your screenshot


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9165.

avatar brianteeman brianteeman - change - 19 Feb 2016
Status New Confirmed
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Feb 2016

ok, please tell me when you can reproduce it so we can test the patch.

avatar infograf768
infograf768 - comment - 19 Feb 2016

@andrepereiradasilva
By playing and moving this line around, I got, once only, the same issue I described originally.
Now I can't reproduce anymore.
I feel it must have been a cache issue when that line was indeed in the if search.

It makes sense to move it just before return $query;

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Feb 2016

my patch revert it to exacly like it was.

I will make a PR with the patch.

avatar brianteeman brianteeman - close - 19 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - close - 19 Feb 2016
avatar brianteeman brianteeman - change - 19 Feb 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-02-19 11:38:51
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 19 Feb 2016

Closed as we have a patch #9166


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9165.

avatar brianteeman brianteeman - close - 19 Feb 2016
avatar brianteeman brianteeman - close - 19 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - change - 20 Feb 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 8 Mar 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment