#9118 has broken correct update proposals in Control Panel.
I have a component com_localise which is set as 4.0.13-dev (modified, this is why I do not update to the available 4.0.14-dev).
It now displays also as a Joomla Update.
Clicking on "Update Now" will load the Joomla Update page where, evidently, no update is proposed.
The Extensions:Update page correcty displays the possible update for the component.
I had to clear the Update cache and then click on Find Updates to get rid of this error.
I am afraid that people updating to 3.5.0 would get the same issue. Any possible solution?
Labels |
Added:
?
|
On 19 February 2016 at 10:56, infograf768 notifications@github.com wrote:
When I reversed #9118 #9118 I
did not get the issue (that was before I cleared cache and click find
updates).
I have another test site where I could not reproduce.—
Reply to this email directly or view it on GitHub
#9165 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
A bit different here, @brianteeman as the issue is that it proposes in Control Panel a Joomla update with a component version + the normal proposal for that component update which works OK.
@infograf768 i think i know what is the issue. a line bad placed inside an if.
i think this line https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/update.php#L146 must be placed outside the if (search).
Can you test?
Update: i have the changes here staging...andrepereiradasilva:patch-2
But i can't test so i will not make a PR if i can't test.
Can you tell me how to reproduce the problem?
Hmm, the problem is that, by clearing cache, the problem disapeared...
I have to find a way to reproduce.
@infograf768 sorry I should have drunk the coffee before replying - i see what you mean now in your screenshot
Status | New | ⇒ | Confirmed |
ok, please tell me when you can reproduce it so we can test the patch.
@andrepereiradasilva
By playing and moving this line around, I got, once only, the same issue I described originally.
Now I can't reproduce anymore.
I feel it must have been a cache issue when that line was indeed in the if search.
It makes sense to move it just before return $query;
my patch revert it to exacly like it was.
I will make a PR with the patch.
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-19 11:38:51 |
Closed_By | ⇒ | brianteeman |
Closed as we have a patch #9166
Labels |
Removed:
?
|
Labels |
Added:
?
|
This has been the case for a LONG time
On 19 February 2016 at 10:45, infograf768 notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/