? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
19 Feb 2016

This PR makes the layout of Options in Menu Item type Featured Articles consistent with Menu Item type Single Article.

IMHO the Options of the Menu Item type "Single Article" (with their colored radio options) look very clear and it's easy to spot all the different settings. The Featured Articles works with drop-down options and is more difficult to see al the settings.

One possible issue with this PR: on Mobile Phones the extra "Use Article Settings" might push the most right option "Show" off the screen. Can we change the language label "Use Article Settings" to "Use Article", just like we have "Use Global" (and not "Use Global Settings") ?

Testing Instructions

Use Joomla with Test English (GB) sample data.

Before the PR

Go to Menus > All Front End Views
Open Menu Item "Single Article (Alias: single-article)" and check [Options]
All options are immediately visible. Clicking on different options will show that they have different colors.

options-menuitem-singlearticle

Go to Menus > All Front End Views
Open Menu Item "Featured Articles (Alias: featured-articles)" and check [Options]
All options look the same with drop-down boxes.

options-menuitem-featuredarticles

After the PR

Go to Menus > All Front End Views
Open Menu Item "Featured Articles (Alias: featured-articles)" and check [Options]
All options are immediately visible. Clicking on different options will show that they have different colors.

options-menuitem-featuredarticles-after

avatar pe7er pe7er - open - 19 Feb 2016
avatar pe7er pe7er - change - 19 Feb 2016
Status New Pending
avatar brianteeman
brianteeman - comment - 19 Feb 2016

@pe7er can you check the current staging it looks to me like this is already fixed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman brianteeman - change - 19 Feb 2016
Status Pending Information Required
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 19 Feb 2016

I NEED coffee - I had applied the patch - doh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman brianteeman - test_item - 19 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Feb 2016

I have tested this item :white_check_mark: successfully on 5202e0e

This works and makes sense - just one small bug
On the row Position of Article Info the final option SPLIT is not displayed on the screen when in mobile


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman
brianteeman - comment - 19 Feb 2016

Sorry about the previous message - I had already applied the patch - need coffee

Just one small issue on mobile - the final option for Position of Article Info (split) does not display on a mobile screen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman brianteeman - change - 19 Feb 2016
Status Information Required Pending
avatar pe7er
pe7er - comment - 19 Feb 2016

Hehe, no Prob! :-)
I would welcome your opinion on the possible issue with Mobile Phone view.

BTW: if this PR gets approved, then I am willing work on the consistency of the "Options layout" for other Menu Item types as well...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman
brianteeman - comment - 19 Feb 2016

The issue on mobile is the length of the text I could propose an alternative text string instead of "Use Article Settings" such as "From Article" which almost works but then it wouldnt work in non en-gb languages

I think from memory that this is why the decision was made that if there were more than two options it would be a select box -but I agree with you its better your way

avatar genesisfan genesisfan - test_item - 19 Feb 2016 - Tested successfully
avatar genesisfan
genesisfan - comment - 19 Feb 2016

I have tested this item :white_check_mark: successfully on 5202e0e

@test successfully tested.
I have not tested on mobile.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar RonakParmar RonakParmar - test_item - 23 Feb 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 23 Feb 2016

I have tested this item :white_check_mark: successfully on 5202e0e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar pe7er
pe7er - comment - 24 Feb 2016

@brianteeman @genesisfan @RonakParmar
Thank you all for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman
brianteeman - comment - 27 Mar 2016

I am setting this to Needs Review because of the question about the mobile view


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar brianteeman brianteeman - change - 27 Mar 2016
Status Pending Needs Review
avatar brianteeman brianteeman - change - 29 Mar 2016
Category Components Templates (admin)
avatar mikeveeckmans mikeveeckmans - test_item - 30 Mar 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on 5202e0e

Works on mobile ( see screenshots in comment )
HOWEVER as @pe7er predicted the "Use Article Settings" is too big for the screen (tested on iphone6)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar mikeveeckmans
mikeveeckmans - comment - 30 Mar 2016

screen shot 2016-03-30 at 16 51 56 before

screen shot 2016-03-30 at 16 52 24 after


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar chrisdavenport
chrisdavenport - comment - 7 May 2016

I like it, but sadly I'm going to have to close it because of the issue with mobile devices.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.

avatar joomla-cms-bot joomla-cms-bot - close - 7 May 2016
avatar chrisdavenport chrisdavenport - change - 7 May 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 15:35:21
Closed_By chrisdavenport
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Closed_Date 2016-05-07 15:35:21 2016-05-07 15:35:22
Closed_By chrisdavenport joomla-cms-bot
avatar chrisdavenport
chrisdavenport - comment - 7 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 7 May 2016
avatar pe7er
pe7er - comment - 7 May 2016

I understand. Thank you all for testing & your input.

Add a Comment

Login with GitHub to post a comment