User tests: Successful: Unsuccessful:
This PR makes the layout of Options in Menu Item type Featured Articles consistent with Menu Item type Single Article.
IMHO the Options of the Menu Item type "Single Article" (with their colored radio options) look very clear and it's easy to spot all the different settings. The Featured Articles works with drop-down options and is more difficult to see al the settings.
One possible issue with this PR: on Mobile Phones the extra "Use Article Settings" might push the most right option "Show" off the screen. Can we change the language label "Use Article Settings" to "Use Article", just like we have "Use Global" (and not "Use Global Settings") ?
Use Joomla with Test English (GB) sample data.
Go to Menus > All Front End Views
Open Menu Item "Single Article (Alias: single-article)" and check [Options]
All options are immediately visible. Clicking on different options will show that they have different colors.
Go to Menus > All Front End Views
Open Menu Item "Featured Articles (Alias: featured-articles)" and check [Options]
All options look the same with drop-down boxes.
Go to Menus > All Front End Views
Open Menu Item "Featured Articles (Alias: featured-articles)" and check [Options]
All options are immediately visible. Clicking on different options will show that they have different colors.
Status | New | ⇒ | Pending |
Status | Pending | ⇒ | Information Required |
Labels |
Added:
?
|
I NEED coffee - I had applied the patch - doh
I have tested this item successfully on 5202e0e
This works and makes sense - just one small bug
On the row Position of Article Info the final option SPLIT is not displayed on the screen when in mobile
Sorry about the previous message - I had already applied the patch - need coffee
Just one small issue on mobile - the final option for Position of Article Info (split) does not display on a mobile screen
Status | Information Required | ⇒ | Pending |
Hehe, no Prob! :-)
I would welcome your opinion on the possible issue with Mobile Phone view.
BTW: if this PR gets approved, then I am willing work on the consistency of the "Options layout" for other Menu Item types as well...
The issue on mobile is the length of the text I could propose an alternative text string instead of "Use Article Settings" such as "From Article" which almost works but then it wouldnt work in non en-gb languages
I think from memory that this is why the decision was made that if there were more than two options it would be a select box -but I agree with you its better your way
I have tested this item successfully on 5202e0e
@test successfully tested.
I have not tested on mobile.
I have tested this item successfully on 5202e0e
@brianteeman @genesisfan @RonakParmar
Thank you all for testing!
I am setting this to Needs Review because of the question about the mobile view
Status | Pending | ⇒ | Needs Review |
Category | ⇒ | Components Templates (admin) |
I have tested this item successfully on 5202e0e
Works on mobile ( see screenshots in comment )
HOWEVER as @pe7er predicted the "Use Article Settings" is too big for the screen (tested on iphone6)
I like it, but sadly I'm going to have to close it because of the issue with mobile devices.
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 15:35:21 |
Closed_By | ⇒ | chrisdavenport |
Closed_Date | 2016-05-07 15:35:21 | ⇒ | 2016-05-07 15:35:22 |
Closed_By | chrisdavenport | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @chrisdavenport by The JTracker Application at issues.joomla.org/joomla-cms/9164
I understand. Thank you all for testing & your input.
@pe7er can you check the current staging it looks to me like this is already fixed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9164.