[#9162] - Do not count all table rows if start offset is 0
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 9162
- Diff
- csthomas:skipgettotalon0
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
A little speed up backend -> com_content -> articles view when you have set page 1 (means start=0).
How to test:
- enable joomla debug (list of sql queries)
- test without patch number queries
- test with patch number of queries (one count less)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | SQL |
Thanks,
I created that patch some time ago, probably for 3.4.4 and
today I try to show this duplicated query but it missing now.
After joomla 3.4.5 this patch do not change too much.
Anyway can be useful to not run getTotal() if not needed.
I have tested this item 
successfully on 881f44e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9162.
This PR has received new commits.
CC: @brianteeman, @grhcj
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9162.
New commit have not change anything, I only rebase to newer stagging branch.
Method getStart() always run getTotal(), but when $start is 0 then calculating $start won't change anything, because $start can not be less than 0.
I think that the patch will be useful for sort queries in order (select from table, select count)
when start=0 (first page)In the future - joomla should not run getTotal() at all if number of fetched rows is less than limit from query and $start is 0. Specially when there is a lots of filters and result contains only a few rows.
| Status | Pending | ⇒ | Ready to Commit |
RTC (maintainer the tests were before a rebase so it should be ok)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9162.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 21:49:56 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item
successfully on 881f44e
I can confirm with this patch there is one less query BUT I really dont know enough about this to understand if there can be other consequences
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9162.