? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
19 Feb 2016

Sql query generated by components/com_content/models/articles.php is usually heavy,
I propose to skip sql join to #__content_frontpage table if it is not used on category view or archive view.

avatar csthomas csthomas - open - 19 Feb 2016
avatar csthomas csthomas - change - 19 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Feb 2016
Category SQL
avatar AmayAgrawal
AmayAgrawal - comment - 25 Feb 2016

Can anyone please elaborate on how to test it.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar csthomas
csthomas - comment - 25 Feb 2016

As an author, I can say that this patch is one of several others that I use on production site (more than 100k articles) for long time without any problems, but I'm interested in any comments.

How to test on front page:

  • go to com_content category view
  • go to com_content categories view
  • go to featured view
  • go to archive view

Test results of modules based on cm_content models:

  • mod_articles_...
avatar csthomas csthomas - change - 29 Feb 2016
Title
Content model - skip sql join to #__content_frontage if not needed
[com_content] Boost sql query by skipping join to #__content_frontage if not needed
avatar csthomas
csthomas - comment - 9 Mar 2016

Explanation:
When articles do not require order by front page ordering then we can skip join and use featured column only in where clause.

avatar andrepereiradasilva andrepereiradasilva - test_item - 29 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Mar 2016

I have tested this item :white_check_mark: successfully on 410d108


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 May 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar alikon alikon - test_item - 8 May 2016 - Tested successfully
avatar alikon
alikon - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 2de59c4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar zero-24 zero-24 - alter_testresult - 8 May 2016 - andrepereiradasilva: Tested successfully
avatar zero-24 zero-24 - change - 8 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 8 May 2016

RTC. Thanks for coding and testing.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 May 2016
Status Ready to Commit Pending
Labels
avatar brianteeman
brianteeman - comment - 8 May 2016

Reset to pending for one extra check


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Removed: ?
avatar zero-24 zero-24 - test_item - 8 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 2de59c4

I can't see problems on the blog view. So i would give this a go.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Pending Ready to Commit
avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you @csthomas!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9161.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 13:08:29
Closed_By Kubik-Rubik
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment